RDKEMW-22632: Order service start after PowerManager - #327
Open
Anand73-n wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a systemd drop-in to ensure wpeframework-networkmanager.service is ordered after wpeframework-powermanager.service, so PowerManager is started first on boot in GNOME-enabled builds.
Changes:
- Add a systemd drop-in setting
After=andWants=forwpeframework-powermanager.service. - Install the new drop-in into
wpeframework-networkmanager.service.dvia the plugin CMake install rules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
plugin/gnome/systemd/gnome-powermanager-dependency.conf |
Introduces the systemd unit drop-in to order NetworkManager after PowerManager and pull it in. |
plugin/CMakeLists.txt |
Installs the new drop-in alongside existing NetworkManager systemd drop-ins when ENABLE_GNOME_NETWORKMANAGER is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anand73-n
force-pushed
the
topic/RDKEMW-21821
branch
from
July 22, 2026 14:36
6add70f to
e0485e4
Compare
Anand73-n
force-pushed
the
topic/RDKEMW-21821
branch
from
July 22, 2026 15:04
e0485e4 to
6fa89ab
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
plugin/gnome/systemd/gnome-powermanager-dependency.conf:3
After=only enforces ordering when both units are already part of the same transaction; it does not ensurewpeframework-powermanager.serviceis started. If the goal is to ensure PowerManager is started before NetworkManager, add a dependency likeWants=(orRequires=if NetworkManager cannot function without it) alongsideAfter=.
[Unit]
# Ensure NetworkManager starts after PowerManager
After=wpeframework-powermanager.service
Anand73-n
force-pushed
the
topic/RDKEMW-21821
branch
from
July 22, 2026 15:51
6fa89ab to
ecb654a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
plugin/gnome/systemd/gnome-powermanager-dependency.conf:3
After=only enforces ordering if both units are started; it does not pull in/activate PowerManager. If the goal is to ensure PowerManager is started before this service, add a dependency (e.g.,Wants=orRequires=) alongsideAfter=so systemd will start PowerManager when NetworkManager is started.
[Unit]
# Ensure NetworkManager starts after PowerManager
After=wpeframework-powermanager.service
Reason for change: Ensure PowerManager service is started before NetworkManager Test procedure: Reboot, then inspect the order units actually started Risks: low Priority: P1 Signed-off-by: Anand N <Anand_N@comcast.com>
Anand73-n
force-pushed
the
topic/RDKEMW-21821
branch
from
July 22, 2026 16:08
ecb654a to
3f3c55f
Compare
Comment on lines
+1
to
+3
| [Unit] | ||
| # Ensure NetworkManager starts after PowerManager | ||
| After=wpeframework-powermanager.service |
Anand73-n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Ensure PowerManager service is started before NetworkManager
Test procedure: Reboot, then inspect the order units actually started
Risks: low
Priority: P1