RavenDB-27069: no-.NET attach mode + make the .NET requirement explicit#15
Open
poissoncorp wants to merge 15 commits into
Open
RavenDB-27069: no-.NET attach mode + make the .NET requirement explicit#15poissoncorp wants to merge 15 commits into
poissoncorp wants to merge 15 commits into
Conversation
configure_external_server(url) / RAVENDB_TEST_SERVER_URL make run_server attach to an existing server instead of booting the embedded one, so tests need no .NET (good for Docker/testcontainers CI). Database-per-test isolation and wait_for_indexing are unchanged. Also inlines the removed CommandLineArgumentEscaper no-op.
…) job The bundled 7.2 server is net10.0, so the embedded job installs .NET 10 (was a fake .NET 8). A new 'attach' job runs a RavenDB service container and points the driver at it with NO .NET, proving the attach path end-to-end (verified locally against ravendb/ravendb:7.2-ubuntu-latest).
… option (link Lab 03)
…> ravendb_test_driver)
…dexes); run both in CI
…yPI yet; Dependabot bumps on release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The test-driver boots an embedded RavenDB server by default, which requires .NET (10 for 7.2.x,
8 for 7.1.x). For containerized CI or machines without .NET there was no supported alternative,
and the requirement was undocumented.
Changes
RavenTestDriver.configure_external_server(url)(or theRAVENDB_TEST_SERVER_URLenv var) points the driver at a server you run yourself (Docker,testcontainers, a shared CI service) instead of booting the embedded one. No .NET on the
machine, and each test still gets its own isolated database.
.NET version table.
python_requires>=3.10(theravendbclient cannot be imported on 3.9).services:RavenDB container, so the no-.NET path is exercised..gitignore(
ravendb_testdriver->ravendb_test_driver) so build artifacts are actually ignored.labs/03): runnable attach-to-server guide (Docker / testcontainers / CI).This package imports from
ravendb-embedded; release together with its RavenDB-27069 PR.