Skip to content

docs: removeOrder3 emits RemoveOrderV3 only on state change #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 1 commit into from
Jun 13, 2026
Merged

docs: removeOrder3 emits RemoveOrderV3 only on state change #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/interface/IRaindexV6.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,9 +452,13 @@ interface IRaindexV6 is IERC3156FlashLender, IInterpreterCallerV4 {

/// Order owner can remove their own orders. Delegated order removal is NOT
/// supported and will revert. Removing an order multiple times or removing
/// an order that never existed are valid, the event will be emitted and the
/// transaction will complete with that order hash definitely, redundantly
/// not live.
/// an order that never existed are valid; the transaction will complete
/// with that order hash definitely, redundantly not live.
///
/// If a live order is removed the Raindex MUST change state, emit a
/// `RemoveOrderV3` event and return true. If the order is not live the
/// Raindex MUST NOT change state, which includes not emitting an event.
/// Instead it MUST return false.
///
/// @param order The `Order` data exactly as it was added.
/// @param tasks Additional tasks to run after the order is removed.
Expand Down
Loading