Skip to content

fix IFlowV5 rainlang example to include three sentinels#470

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-424-iflowv5-rainlang-example
Open

fix IFlowV5 rainlang example to include three sentinels#470
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-424-iflowv5-rainlang-example

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Summary

The IFlowV5 rainlang example showed only one sentinel as a stack item. A valid flow stack requires three sentinels (one terminator per token-type group): LibFlow.stackToFlow calls consumeSentinelTuples three times.

Following the previous example produced an invalid stack — consumeSentinelTuples for erc721 and erc20 would pull from below the intended boundary rather than terminating cleanly.

The fix mirrors test/lib/LibStackGeneration.sol::generateFlowStack:

  • bottom: erc1155 terminator sentinel + erc1155 tuples
  • middle: erc721 terminator sentinel + erc721 tuples
  • top: erc20 terminator sentinel + erc20 tuples

Closes #424.

Test plan

  • NatSpec-only

🤖 Generated with Claude Code

The example showed only one sentinel as a stack item. A valid flow
stack requires three (one terminator per token-type group). The fix
mirrors test/lib/LibStackGeneration.sol::generateFlowStack: at the
bottom of the stack, an erc1155 terminator sentinel, then erc1155
tuples; an erc721 terminator sentinel, then erc721 tuples; an erc20
terminator sentinel, then erc20 tuples.

Following the previous example produced an invalid stack:
consumeSentinelTuples for erc721 and erc20 would pull from below
rather than terminating cleanly.

Closes #424.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 37 minutes and 21 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6f8fd391-ce5b-47e0-a1a1-653987e58c52

📥 Commits

Reviewing files that changed from the base of the PR and between ceaea3c and b5496bd.

📒 Files selected for processing (1)
  • src/interface/IFlowV5.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-07-issue-424-iflowv5-rainlang-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister self-assigned this May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A22-6] [MEDIUM] IFlowV5 rainlang example stack omits inter-type sentinels

1 participant