fix Flow constructor NatSpec to match implementation#463
fix Flow constructor NatSpec to match implementation#463thedavidmeister wants to merge 1 commit into
Conversation
The previous NatSpec claimed the constructor "forwards config to `DeployerDiscoverableMetaV2`". Neither is true: the constructor takes no parameters and forwards nothing, and `DeployerDiscoverableMetaV2` is not in `Flow`'s inheritance chain or imported anywhere — it's a dangling reference to a removed dependency. NatSpec rewritten to describe what the constructor actually does: disable initializers so the implementation is unusable directly and all instances must be proxies / clones initialized via a factory. Closes #347. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
The
Flowconstructor NatSpec claimed it "forwards config toDeployerDiscoverableMetaV2". Neither is true: the constructor takes no parameters and forwards nothing, andDeployerDiscoverableMetaV2is not in the inheritance chain or imported anywhere — a dangling reference to a removed dependency.NatSpec rewritten to describe what the constructor actually does: disable initializers so the implementation is unusable directly and all usable instances must be proxies / clones initialized via a factory.
Closes #347.
Test plan
🤖 Generated with Claude Code