specify UnregisteredFlow.unregisteredHash preimage in NatSpec#462
specify UnregisteredFlow.unregisteredHash preimage in NatSpec#462thedavidmeister wants to merge 2 commits into
Conversation
The previous "Hash of the unregistered flow" docstring was circular — it didn't tell an integrator what was hashed. The value is `LibEvaluable.hash(EvaluableV2)` over `(interpreter, store, expression)`, which is also the key in `registeredFlows`. NatSpec now states this explicitly so an integrator catching the error can hash a locally-known evaluable triple and identify which one was rejected. Closes #346. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 6 minutes and 56 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…unregistered-flow-natspec
|
Reviewed ffb80b0: specify UnregisteredFlow.unregisteredHash preimage in NatSpec — rebased onto main (test-only union conflict resolution + forge fmt), all checks green. LGTM. |
2 participants
Summary
Specifies the preimage in the
UnregisteredFlow.unregisteredHashNatSpec —LibEvaluable.hash(EvaluableV2)over(interpreter, store, expression), which is also the key in theregisteredFlowsmapping.Closes #346.
Test plan
🤖 Generated with Claude Code