standardise loop increment to ++i across LibFlow siblings#456
Conversation
flowERC721 used ++i; flowERC20 and flowERC1155 used i++. All three loops are unchecked so the codegen is identical, but the sibling functions should look identical. Standardised on ++i. Closes #416. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 35 minutes and 31 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…libflow-loop-increment-style
|
Reviewed db4cf6d: standardise loop increment to ++i across LibFlow siblings — rebased onto main (test-only union conflict resolution + forge fmt), all checks green. LGTM. |
Summary
flowERC721used++i;flowERC20andflowERC1155usedi++. All three loops are insideuncheckedblocks so the codegen is identical, but the sibling functions should look identical. Standardised on++i.Closes #416.
Test plan
forge buildclean🤖 Generated with Claude Code