remove dead Pointer import from IFlowV5#455
Open
thedavidmeister wants to merge 1 commit into
Open
Conversation
`Pointer` was imported with a forge-lint unused-import suppression but no consumer re-imports it from this interface — unlike the other suppressed imports in the file (Sentinel, RAIN_FLOW_SENTINEL, the transfer structs) which all have downstream callers. The suppression was hiding a genuinely unused import. Closes #415. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Walkthrough
ChangesImport Addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pointerwas imported inIFlowV5.solwith aforge-lint: disable-next-line(unused-import)suppression, but no consumer re-imports it from this interface. Other suppressed imports in the file (Sentinel,RAIN_FLOW_SENTINEL,ERC20Transfer/ERC721Transfer/ERC1155Transfer,MIN_FLOW_SENTINELS) all have downstream callers. The suppression was hiding a genuinely unused import.Closes #415.
Test plan
forge buildclean🤖 Generated with Claude Code
Summary by CodeRabbit