proto: reject stream flow-control frames above limits#2651
Open
GHX5T-SOL wants to merge 1 commit into
Open
Conversation
djc
approved these changes
May 20, 2026
| ); | ||
| } | ||
| Frame::StopSending(frame::StopSending { id, error_code }) => { | ||
| if id.initiator() != self.side.side() { |
Member
There was a problem hiding this comment.
I'd like for this to be a separate commit.
Ralith
approved these changes
May 21, 2026
| ); | ||
| } | ||
| Frame::StopSending(frame::StopSending { id, error_code }) => { | ||
| if id.initiator() != self.side.side() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2650.
Summary
STOP_SENDINGandMAX_STREAM_DATASTREAM_LIMIT_ERRORfor remote-initiated bidirectional stream IDs above the advertised limitValidation
cargo test --locked -p quinn-proto stream_limitpassed: 5 passed, 0 failedcargo test --locked -p quinn-protopassed: 273 unit tests and 3 doctests passedcargo fmt --all -- --checkpassedcargo clippy --locked -p quinn-proto --all-targets -- -D warningspassedcargo test --locked --manifest-path fuzz/Cargo.tomlpassedRUSTFLAGS='--cfg fuzzing' cargo build --locked --manifest-path fuzz/Cargo.toml --bin streamspassedgit diff --checkpassedgitleaks protect --staged --redact --no-bannerpassed: no leaks foundNote: #2601 also touches remote stream allocation state; this PR is against current
mainand may need a rebase if #2601 lands first.