Skip to content

Upgrade to rand 0.10#2643

Open
ww-oai wants to merge 2 commits into
quinn-rs:mainfrom
ww-oai:ww/rand-0.10
Open

Upgrade to rand 0.10#2643
ww-oai wants to merge 2 commits into
quinn-rs:mainfrom
ww-oai:ww/rand-0.10

Conversation

@ww-oai
Copy link
Copy Markdown

@ww-oai ww-oai commented May 13, 2026

This is atop #2531. The main things I've done are switch to PCG as the RNG impl, plus make a previous implicit (rand-side) panic explicit (on the quinn side).

Closes #2531. Closes #2636.

@ww-oai ww-oai marked this pull request as ready for review May 13, 2026 15:08
Comment thread Cargo.lock Outdated
@djc
Copy link
Copy Markdown
Member

djc commented May 13, 2026

This is atop #2531. The main things I've done are switch to PCG as the RNG impl, plus make a previous implicit (rand-side) panic explicit (on the quinn side).

I think we'd prefer to squash all these changes into a single commit (which we'll end up rebasing onto main). But, do you think it could make sense to isolate the switch to PCG in a separate commit?

@woodruffw
Copy link
Copy Markdown

I think we'd prefer to squash all these changes into a single commit (which we'll end up rebasing onto main). But, do you think it could make sense to isolate the switch to PCG in a separate commit?

Yeah, can do!

@ww-oai ww-oai force-pushed the ww/rand-0.10 branch 2 times, most recently from 7e797cd to 2dbdabc Compare May 13, 2026 15:27
@ww-oai
Copy link
Copy Markdown
Author

ww-oai commented May 13, 2026

Okay, rewrote the branch's history; the base commit is now the rand bump, and the next commit adds PCG via rand_pcg.

(Also, so sorry for all the account switches. Still trying to develop muscle memory around that...)

@djc
Copy link
Copy Markdown
Member

djc commented May 13, 2026

(Also, so sorry for all the account switches. Still trying to develop muscle memory around that...)

No worries, I caught on to ww-oai pretty quickly... was a little surprised that I have to approve workflows for you even though we only restrict workflows for people new to GitHub. 😄

Comment thread quinn-proto/src/endpoint.rs
Comment thread Cargo.toml
Comment thread Cargo.toml Outdated
@djc
Copy link
Copy Markdown
Member

djc commented May 13, 2026

Might be nice to retain me as co-author on the first commit?

@ww-oai
Copy link
Copy Markdown
Author

ww-oai commented May 13, 2026

Might be nice to retain me as co-author on the first commit?

Oops, yes. Fixing that...

@ww-oai ww-oai force-pushed the ww/rand-0.10 branch 2 times, most recently from 28be735 to d27ec39 Compare May 13, 2026 16:00
Comment thread quinn-proto/src/congestion/bbr/mod.rs
Copy link
Copy Markdown
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ww-oai and others added 2 commits May 14, 2026 11:26
Make Endpoint::new panicking on CSPRNG init failure.

Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
@Ralith Ralith enabled auto-merge May 14, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump the rand crate to 0.10?

4 participants