Add interconnect node for Lemans, Monaco, Kodiak, Talos by bibekpatro · Pull Request #616 · qualcomm-linux/kernel

bibekpatro · 2026-05-26T20:28:32Z

Add interconnect node for adreno smmu for Lemans, Monaco, Kodiak, Talos targets
Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t
CRs Fixed: 4523338

…no SMMU On Kodiak platforms, the Adreno SMMU requires a bandwidth vote on the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers are accessible. Without this vote, the SMMU may become unreachable, leading to intermittent probe failures and runtime issues. Add the required interconnect to ensure reliable register access. Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

…no SMMU On Lemans platforms, the Adreno SMMU requires a bandwidth vote on the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers are accessible. Without this vote, the SMMU may become unreachable, leading to intermittent probe failures and runtime issues. Add the required interconnect to ensure reliable register access. Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

…no SMMU On Monaco platforms, the Adreno SMMU requires a bandwidth vote on the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers are accessible. Without this vote, the SMMU may become unreachable, leading to intermittent probe failures and runtime issues. Add the required interconnect to ensure reliable register access. Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

…o SMMU On Talos platforms, the Adreno SMMU requires a bandwidth vote on the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers are accessible. Without this vote, the SMMU may become unreachable, leading to intermittent probe failures and runtime issues. Add the required interconnect to ensure reliable register access. Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

qswat-orbit-external · 2026-05-26T20:28:40Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qlijarvis · 2026-05-26T21:45:12Z

PR #616 — validate-patch

PR: #616

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: Yes — but all 4 commits incorrectly link to the cover letter (-v2-0-) instead of their individual patch message-IDs
Lore link matches PR commits: Cannot verify — network restricted; cannot fetch upstream patches for diff comparison. However, commit 1 has a critical subject/file mismatch (says "kodiak" but modifies sc7280.dtsi) which must be fixed regardless of upstream content.
Upstream patch status: ⏳ Decision Pending — posted 2026-05-26 (today); likely still under review. Cannot verify acceptance/rejection signals due to network restrictions.
PR present in qcom-next: No — these commits are not yet in qcom-next (searched by subject, author, and file path)

Verdict: ❌ — click to expand

🔍 Patch Validation Report

PR: #616
Upstream: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
Verdict: ❌ FAIL

Summary of Commits

This PR contains 4 commits, all marked as FROMLIST: (except commit 1 which has a typo), adding GEM_NOC interconnects for Adreno SMMU on different platforms.

# Platform File Modified Prefix Issues

1 kodiak (claimed) sc7280.dtsi IFROMLIST (typo) ❌ Subject/file mismatch, prefix typo

2 lemans lemans.dtsi FROMLIST: ⚠️ Wrong lore link

3 monaco monaco.dtsi FROMLIST: ⚠️ Wrong lore link

4 talos talos.dtsi FROMLIST: ⚠️ Wrong lore link

Critical Issues Found

1. Commit 1: Subject/Content Mismatch ❌

Subject line: IFROMLIST arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU
File modified: arch/arm64/boot/dts/qcom/sc7280.dtsi

The subject claims to modify "kodiak" but the actual file is sc7280.dtsi. This is a critical error.

Expected: Subject should say sc7280 not kodiak, OR the file should be kodiak.dtsi if that's the intended target.

2. Commit 1: Prefix Typo ❌

Current: IFROMLIST (missing colon, extra 'I')
Expected: FROMLIST:

The prefix should be FROMLIST: with a colon, not IFROMLIST.

3. All Commits: Wrong Lore Link ⚠️

All four commits link to the same message-ID (the cover letter):
Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t
The -v2-0- indicates this is the cover letter (patch 0 of the series). Each commit should link to its individual patch message-ID:

Commit 1 (sc7280) → should link to -v2-1-... message-ID

Commit 2 (lemans) → should link to -v2-2-... message-ID

Commit 3 (monaco) → should link to -v2-3-... message-ID

Commit 4 (talos) → should link to -v2-4-... message-ID

Impact: Without network access, I cannot fetch the individual patch message-IDs to verify the diff content matches upstream. However, linking to the cover letter instead of individual patches violates the Link: tag convention and makes it impossible to trace each commit back to its specific upstream posting.

Commit Message Analysis

Check Commit 1 Commits 2-4 Notes

Subject matches file ❌ FAIL ✅ PASS Commit 1: says "kodiak" but modifies sc7280.dtsi

Prefix correct ❌ FAIL ✅ PASS Commit 1: IFROMLIST should be FROMLIST:

Body preserves rationale ✅ PASS ✅ PASS Clear explanation of GEM_NOC requirement

Fixes tag present N/A N/A Not applicable for new feature additions

Authorship preserved ✅ PASS ✅ PASS From: matches Signed-off-by: (same author)

Lore link present ⚠️ PARTIAL ⚠️ PARTIAL Links to cover letter, not individual patches

Backport note N/A N/A Not a backport (FROMLIST: prefix)

Diff Comparison

Status: ⏭️ Cannot verify — network access restricted; cannot fetch upstream lore patches for comparison.

What can be verified locally:

File Hunks Local Check Notes

sc7280.dtsi 1 ⚠️ Subject mismatch Subject says "kodiak" but file is sc7280

lemans.dtsi 1 ✅ Consistent Subject matches file

monaco.dtsi 1 ✅ Consistent Subject matches file

talos.dtsi 1 ✅ Consistent Subject matches file

All diffs follow the same pattern:
+			interconnects = <&gem_noc MASTER_GPU_TCU QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
This is consistent with the commit message description (adding GEM_NOC interconnect for Adreno SMMU).

Upstream Patch Status

Status: ⏳ Decision Pending (cannot verify — network restricted)

Reason: Network access is restricted; cannot fetch the lore thread to check for:

Maintainer acceptance signals (applied, queued, Reviewed-by:, Acked-by:)

Rejection signals (NAK, Nacked-by:)

Superseded revisions (v3, v4, etc.)

Date posted: 2026-05-26 (based on message-ID timestamp)
Age: Same day as PR submission — very recent posting

Expected status: Given the recent posting date (today), the patches are likely still under review on the mailing list.

qcom-next Presence

Status: ⚠️ Not found in qcom-next

Searched the canonical qcom-next branch at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel:

Commit Search Method Result

sc7280 GEM_NOC Subject grep Not found

lemans GEM_NOC Subject grep Not found

monaco GEM_NOC Subject grep Not found

talos GEM_NOC Subject grep Not found

Author: bibek.patro (recent) Author search Found other commits, but not these

Conclusion: These patches have not yet landed in qcom-next. This is consistent with them being posted to the mailing list today (2026-05-26) and still under review.

Dependency Check

✅ No missing dependencies detected

All four commits are self-contained device tree additions with no cross-dependencies. Each adds the same interconnect property to a different platform's Adreno SMMU node.

Recommendation

DO NOT MERGE until the following issues are corrected:

Required fixes:

Commit 1 — Fix subject/file mismatch:

Option A: Change subject from "kodiak" to "sc7280" to match the file being modified

Option B: If the intent was to modify kodiak.dtsi, change the file path in the diff

Commit 1 — Fix prefix typo:

Change IFROMLIST to FROMLIST: (add colon, remove extra 'I')

All commits — Fix lore links:

Replace the cover letter link (-v2-0-) with individual patch message-IDs:

Commit 1 → link to the sc7280 patch message-ID (-v2-1-... or similar)

Commit 2 → link to the lemans patch message-ID (-v2-2-... or similar)

Commit 3 → link to the monaco patch message-ID (-v2-3-... or similar)

Commit 4 → link to the talos patch message-ID (-v2-4-... or similar)

Recommended workflow:

Fetch the individual patch message-IDs from the lore thread

Amend each commit with the correct Link: tag

Fix commit 1's subject line and prefix

Force-push the corrected commits to the PR

Wait for upstream acceptance signals before merging (or document why merging before upstream acceptance is acceptable for this tree)

Final Summary

Lore link present: Yes — but all 4 commits incorrectly link to the cover letter (-v2-0-) instead of their individual patch message-IDs

Lore link matches PR commits: Cannot verify — network restricted; cannot fetch upstream patches for diff comparison. However, commit 1 has a critical subject/file mismatch (says "kodiak" but modifies sc7280.dtsi) which must be fixed regardless of upstream content.

Upstream patch status: ⏳ Decision Pending — posted 2026-05-26 (today); likely still under review. Cannot verify acceptance/rejection signals due to network restrictions.

PR present in qcom-next: No — these commits are not yet in qcom-next (searched by subject, author, and file path)

Verdict Justification

❌ FAIL — Critical errors prevent merging:

Commit 1 has a subject/file mismatch (kodiak vs sc7280.dtsi)

Commit 1 has a prefix typo (IFROMLIST instead of FROMLIST:)

All commits link to the wrong message-ID (cover letter instead of individual patches)

These are objective, verifiable errors that must be corrected before the PR can be merged, regardless of whether the upstream patches are eventually accepted.

qlijarvis · 2026-05-26T21:45:13Z

PR #616 — checker-log-analyzer

PR: #616
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26473355115

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All commits pass style checks
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	All DTB validations pass
sparse-check	⏭️	Skipped (no C/H files changed)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	2 blockers: invalid prefix + link issues
tag-check	❌	1 blocker: commit 1 has invalid prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #616 - Add GEM_NOC interconnect for adreno SMMU across multiple platforms
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26473355115
Target branch: qcom-6.18.y

Checker Result Summary

checkpatch ✅ All commits pass style checks

dt-binding-check ⏭️ Skipped (no binding changes)

dtb-check ✅ All DTB validations pass

sparse-check ⏭️ Skipped (no C/H files changed)

check-uapi-headers ⏭️ Skipped (no UAPI changes)

check-patch-compliance ❌ 2 blockers: invalid prefix + link issues

tag-check ❌ 1 blocker: commit 1 has invalid prefix

❌ check-patch-compliance

Root cause: Commit 1 has an invalid prefix typo (IFROMLIST instead of FROMLIST:), and all commits link to a cover letter instead of individual patches.

Failure details:
Checking commit: IFROMLIST arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU
Commit summary does not start with a required prefix

Checking commit: FROMLIST: arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t

Checking commit: FROMLIST: arm64: dts: qcom: monaco: Add GEM_NOC interconnect for adreno SMMU
Something seems wrong with the provided link. Please verify it

Checking commit: FROMLIST: arm64: dts: qcom: talos: Add GEM_NOC interconnect for adreno SMMU
Something seems wrong with the provided link. Please verify it
Issues identified:

Commit 1 (2d13c75) - Invalid prefix:

Subject: IFROMLIST arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU

Problem: IFROMLIST is not a valid prefix (typo - missing colon and extra I)

Should be: FROMLIST:

Commits 2-4 - Invalid link format:

All commits link to: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/#t

Problem: The #t fragment points to the cover letter (message 0), not individual patches

The checker's b4 am --single-message cannot fetch a cover letter as a patch

Fix:

For commit 1 - fix the prefix typo:
git rebase -i aea160c9d9f450a5472014ba76dd117ce476a607
# Mark commit 2d13c758f9ca as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU

On Kodiak platforms, the Adreno SMMU requires a bandwidth vote on
the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers
are accessible. Without this vote, the SMMU may become unreachable,
leading to intermittent probe failures and runtime issues.

Add the required interconnect to ensure reliable register access.

Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-1-2a6d8ca30d63@oss.qualcomm.com/
Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>"
git rebase --continue
For commits 2-4 - fix the Link tags:

Each commit should link to its individual patch message, not the cover letter:

Commit 2 (lemans): Change link to https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-2-2a6d8ca30d63@oss.qualcomm.com/

Commit 3 (monaco): Change link to https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-3-2a6d8ca30d63@oss.qualcomm.com/

Commit 4 (talos): Change link to https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-4-2a6d8ca30d63@oss.qualcomm.com/

The pattern is: replace -v2-0- (cover letter) with -v2-N- where N is the patch number (1, 2, 3, 4), and remove the #t fragment.

Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git aea160c9d9f4..bcd7bbcfd30a
cd ../kernel-checkers
bash check-patch-compliance.sh --kernel-src ../kernel --base aea160c9d9f4 --head bcd7bbcfd30a
❌ tag-check

Root cause: Commit 1 subject line starts with IFROMLIST which is not a valid prefix tag.

Failure details:

Target branch qcom-6.18.y requires all commits to start with a valid prefix. Commit 1 has:
Subject: IFROMLIST arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU
Valid prefixes are: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:

IFROMLIST is not in this list (appears to be a typo for FROMLIST:).

Fix:

Same as the fix for check-patch-compliance above - change IFROMLIST to FROMLIST: in commit 1:
git rebase -i aea160c9d9f450a5472014ba76dd117ce476a607
# Mark commit 2d13c758f9ca as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU
<rest of commit message unchanged>"
git rebase --continue
Reproduce locally:
git log aea160c9d9f4..bcd7bbcfd30a --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING/INVALID prefix: $sha $subject"
  fi
done
Verdict

3 blockers must be fixed before merge:

Commit 1: Change IFROMLIST → FROMLIST: (typo in prefix)

Commit 1: Update Link to point to patch 1 instead of cover letter

Commits 2-4: Update Link tags to point to individual patches (2, 3, 4) instead of cover letter

All other checkers passed or skipped appropriately. Once the prefix typo and Link tags are corrected, the PR should pass all checks.

bibekpatro and others added 5 commits May 27, 2026 01:55

Merge branch 'qualcomm-linux:qcom-6.18.y' into qcom-6.18.y

bcd7bbc

bibekpatro requested review from a team, aiquny, quic-kaushalk and shashim-quic May 26, 2026 20:28

Conversation

bibekpatro commented May 26, 2026

Uh oh!

qswat-orbit-external Bot commented May 26, 2026

Uh oh!

qlijarvis commented May 26, 2026

PR #616 — validate-patch

Final Summary

🔍 Patch Validation Report

Summary of Commits

Critical Issues Found

1. Commit 1: Subject/Content Mismatch ❌

2. Commit 1: Prefix Typo ❌

3. All Commits: Wrong Lore Link ⚠️

Commit Message Analysis

Diff Comparison

Upstream Patch Status

qcom-next Presence

Dependency Check

Recommendation

Required fixes:

Recommended workflow:

Final Summary

Verdict Justification

Uh oh!

qlijarvis commented May 26, 2026

PR #616 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

❌ tag-check

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants