chore: adopt linecheck for per-file line-count enforcement#184
Merged
Conversation
Adds linecheck.yml (rust files warn at 200 lines, error at 1100 — a buffer above the current largest file so CI stays green) and a linecheck CI job that installs via cargo and runs `linecheck .`. Closes #183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183
What
linecheck.ymlat the repo root:**/*.rswarns at 200 lines, errors at 1100 lines.linecheckjob to.github/workflows/ci.yml(installs viacargo install linecheck --locked, runslinecheck .).Why 1100 and not the tool's default 400?
core/src/run.rsis currently 1000 lines. Gating at the tool default (400) would fail every PR immediately. Starting the error threshold at 1100 (buffer above the current max) keeps CI green today while still catching new runaway growth and surfacing every file over 200 lines as a non-blocking warning. Lower the gate in follow-up PRs as files get split — seemoadim-io/daemon's history for the iterative pattern.Verification
Ran locally against this repo:
All warnings, no errors — the new CI job will pass.