chore(npm): pin the framework files map to its governed surface#174
Merged
Conversation
Drop the ESP32-P4 PPA crate from the npm tarball: it has no pocket CLI target, nothing in the shipped surface consumes it, and its ESP-IDF C component half cannot ship in npm — the integration is git-only by design. Also drop the tools/cli/psp-toolchain.json entry, which the wholesale tools entry already covers (tarball diff is exactly the five esp32p4 files). Encode the rule in tests/npm-package.test.ts: a closed-form assertion of the files array plus negative tarball checks, so a files entry can only land by deliberately updating the governed list in the same PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governance pass over the
@pocketjs/frameworknpm surface, prompted by #160 addingengine/backends/esp32p4-ppa/*to thefilesmap.filesprinciple is "ship what the framework runtime, compiler, shipped tools, or apocketCLI target consumes from the tarball". ESP32-P4 has no CLI target and no entry incontracts/spec/platforms.ts, nothing in the shipped surface references the crate, and its other half — thehosts/esp32p4/components/pocketjs_ppaESP-IDF C component — cannot meaningfully ship in npm. The integration is a git-checkout workflow per its own README; shipping half of it only signals support that isn't there.tools/cli/psp-toolchain.jsonentry — the wholesaletoolsentry already ships it (verified: the tarball diff for this PR is exactly the five esp32p4 files, 213 → 208).tests/npm-package.test.tsnow asserts thefilesarray exactly, with the principle documented inline, plus negative tarball checks forengine/backends/**andhosts/esp32p4/**. New surface entries now require deliberately editing the governed list in the same PR.Audit notes (checked, deliberately kept)
pocket3d-vita+pocket3d-bsp: explicitly test-pinned standalone crate pair for out-of-tree Vita 3D apps; self-contained in the tarball ([[example]]target requires shippingexamples/). Vita is a first-class CLI target.pocket.json: load-bearing —tools/demo-identity.tsreads it as the fallback manifest template; also the shipped v2 manifest example.pocket.config.ts,tsconfig.json,assets/*,hosts/web,engine/core|wasm,hosts/psp|vita: all traced to shipped consumers.hosts/web/pocketjs.wasmis packed from local disk state andtools/release-check.tshas no freshness guard for it — worth a follow-up tripwire.Validation
npm pack --dry-runbefore/after diff: exactly the 5 esp32p4 files removed.bun test tests/npm-package.test.ts tests/release-check.test.ts tests/cli.test.ts tests/psp-toolchain.test.ts: 22 pass.bun run testchain: green.🤖 Generated with Claude Code