Skip to content

Guard against null gridApi in onSortChanged #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 2 commits into
base: v35
Choose a base branch
from
+3 −1
Open

Guard against null gridApi in onSortChanged #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6cd2cb
Guard against null gridApi in onSortChanged
SAY-5 Jun 18, 2026
4e1a42e
Merge branch 'v35' into fix-sortchanged-null-gridapi
BSd3v Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source Dash AG Grid repo

## [unreleased]

### Added
- [#453](https://github.com/plotly/dash-ag-grid/pull/453) Test for changelog entry

Expand All @@ -17,6 +18,7 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D
- [#454](https://github.com/plotly/dash-ag-grid/pull/454) fixes issue where a rowCount of 0 would cause the grid not to display new data
- [#459](https://github.com/plotly/dash-ag-grid/pull/459) removes `getRowsRequest` / `getRowsResponse` warnings by excluding these Dash callback props from AG Grid options.
- [#460](https://github.com/plotly/dash-ag-grid/pull/460) fix grid rendering when `getRowId` is explicitly set to `None`
- [#466](https://github.com/plotly/dash-ag-grid/issues/466) guard against a null `gridApi` in `onSortChanged`, which threw an uncaught `TypeError` when a grid initialized with a sort applied via `initialState.sort.sortModel`

## [35.2.0] - 2026-04-03
### Added
Expand Down
2 changes: 1 addition & 1 deletion src/lib/fragments/AgGrid.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ export function DashAgGrid(props) {
if (rowModelType === 'clientSide') {
propsToSet.virtualRowData = virtualRowData();
}
if (!gridApi.isDestroyed()) {
if (gridApi && !gridApi?.isDestroyed()) {
propsToSet.columnState = JSON.parse(
JSON.stringify(gridApi.getColumnState())
);
Expand Down
Loading