chore: upgrade SDK catalog + block structure, fix build errors - #5
Conversation
Bump SDK catalog to model/ui-vue 1.80.10 (and related tooling) and apply
the block-tools structure upgrade. Fix the errors surfaced by the upgrade:
- workflow: migrate exec resource request from deprecated .cpu()/.mem()/
.gpuMemory() setters to the .resources({ onCPU, onGPU }) API (adaptive
GPU/CPU); also fixes a pre-existing syntax error
- pin vue to exact 3.5.24 so ui and ui-vue share one copy (fixes the
SdkPluginV2-vs-Vue-Plugin type mismatch)
- drop the removed "@platforma-sdk/ui-vue/styles" import
- rename model export model -> platforma and update the ui consumer,
matching the new structure convention the regenerated block facade expects
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
| node-version: '20.x' | ||
| build-script-name: 'build' | ||
| pnpm-recursive-build: false | ||
|
|
There was a problem hiding this comment.
Workspace test executables are missing
When CI runs the newly enabled test phase, the root script delegates to turbo run test, which executes the retained test: vitest scripts in the model and UI workspaces even though this change removes their Vitest dependencies, causing the build workflow to terminate with vitest: command not found.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/build.yaml
Line: 30
Comment:
**Workspace test executables are missing**
When CI runs the newly enabled test phase, the root script delegates to `turbo run test`, which executes the retained `test: vitest` scripts in the model and UI workspaces even though this change removes their Vitest dependencies, causing the build workflow to terminate with `vitest: command not found`.
How can I resolve this? If you propose a fix, please make it concise.| init: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: milaboratory/github-ci/actions/context/init@v4 |
There was a problem hiding this comment.
Release actions use mutable tags
The new stable-release workflow loads both its initialization action and publishing workflow through mutable v4 tags while passing npm and AWS credentials, allowing a moved upstream tag to run unreviewed code with release credentials. Pin both references to reviewed commit SHAs. How this was verified: the workflow uses tag-based uses references and passes publishing credentials to the referenced workflow.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/mark-stable.yaml
Line: 8
Comment:
**Release actions use mutable tags**
The new stable-release workflow loads both its initialization action and publishing workflow through mutable `v4` tags while passing npm and AWS credentials, allowing a moved upstream tag to run unreviewed code with release credentials. Pin both references to reviewed commit SHAs. **How this was verified:** the workflow uses tag-based `uses` references and passes publishing credentials to the referenced workflow.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
The root package.json pinned @platforma-sdk/block-tools to a local file: tarball (a dev override), which leaked into the commit and broke CI (ENOENT on a path that only exists locally). Remove the pnpm.overrides block and regenerate the lockfile against the catalog version (2.12.9). Add a changeset for the SDK/structure upgrade and the accompanying fixes.
Both packages declared `test: vitest` but have no vitest dependency and no test files (the workflow vitest setup was removed in the structure upgrade). CI's `turbo run test` failed with `vitest: not found`. Drop the scripts so turbo skips these packages, matching the clonotype-space block.
Summary
Upgrades the SDK catalog and applies the
block-tools structureupgrade, then fixes the build/type/runtime errors the upgrade surfaced.Upgrade
@platforma-sdk/model&ui-vue→1.80.10,workflow-tengo→6.8.2,package-builder→3.14.2,block-tools→2.12.9,ts-builder→1.6.1, plus related tooling.block/src/facade, removed legacyblock/index.{js,d.ts}andworkflow/{tsconfig.json,vitest.config.mts}, addedmark-stableworkflow.Fixes
.cpu()/.mem()/.gpuMemory()setters to.resources({ onCPU, onGPU })(adaptive: GPU allocation when the backend has one, CPU fallback otherwise), matchingclonotype-space. Also fixes a pre-existing syntax error in the old code.vueversion — pinned to exact3.5.24(was^3.5.24), souiandui-vueresolve a single copy. FixesTS2345: SdkPluginV2 ... not assignable to Vue Plugin.ui-vue/styles— removed theimport "@platforma-sdk/ui-vue/styles"; the newui-vuedropped that export.model→platformaand updated the UI consumer, matching the convention the regenerated block facade expects. FixesTS2305: has no exported member 'platforma'.Verification
pnpm run checkpasses all 8 tasks (type-check, lint, format, build across model/ui/workflow/block/software).Greptile Summary
Upgrades the Platforma SDK/toolchain and regenerates the block facade while adapting workflow resource allocation and package structure.
modeltoplatforma, describes arguments, UI state, outputs, sections, and GPU report types; consumers now use the new export.onCPUandonGPUresource variants.Confidence Score: 3/5
The CI test failure should be fixed before merging; pinning the new release workflow dependencies is also recommended.
Testing is newly enabled, but the model and UI test scripts invoke an executable those workspaces no longer declare, so pull-request and release builds can fail before completion.
Files Needing Attention: .github/workflows/build.yaml, model/package.json, ui/package.json, .github/workflows/mark-stable.yaml
Security Review
The new stable-release workflow references mutable
v4action tags while passing npm and AWS credentials. Pin both references to reviewed commit SHAs. How this was verified: the workflow’susesentries are tag-based and its secrets block passes publishing credentials to the referenced workflow.Important Files Changed
platformawithout changing its model contract.platformamodel export.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Model[Platforma model] --> Facade[Generated block facade] Model --> UI[Vue UI] UI --> Args[Block arguments] Args --> Workflow[Tengo workflow] Workflow --> Resources{GPU requested?} Resources -->|Yes| Adaptive[onCPU / onGPU allocation] Resources -->|No| CPU[onCPU allocation] Adaptive --> Software[GPU-info Python package] CPU --> Software Software --> Report[GPU report and logs] Facade --> Pack[Published block pack]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: upgrade SDK catalog + block struc..." | Re-trigger Greptile
Context used: