Safari cookie duration hotfix - #389
Open
jzgom067 wants to merge 3 commits into
Open
Conversation
WalkthroughThe frontend now documents the ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d0beb82f-b088-4aa5-8dfa-be1b8a642e75
📒 Files selected for processing (2)
frontend/.env.examplefrontend/src/middleware.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered an issue where, on Safari, our session cookies are limited to only having a lifetime of 7 days, despite the intended duration being 1 year for guests and accounts with "remember me" checked on login.
This happens because of Safari's ITP (Intelligent Tracking Prevention), which, to explain it simply, doesn't like that our frontend and backend are on very different servers. Thus, it limits the cookie lifetime to prevent tracking.
The solution I implemented is a bit of a band-aid fix, similar to the host-only cookie deletion. It adds logic to the Next.js middleware that extends the lifetime of all session cookies on every request to 1 year. This works because our domain maps directly to the frontend server, so cookies from there will be treated just fine. In addition, the backend validates every session cookie it accepts, so this won't cause any problems with expired sessions.
The long-term solution for this would be either: