Release v0.1.4 — two safety rails learned the hard way - #15
Merged
Conversation
Both rails in this release exist because the missing guard actually cost money on a live account, not because they seemed prudent: - `quote recenter|provision`: `--min-ask` now DEFAULTS to the position's break-even (#13). It was optional, so it only applied when remembered — and it got forgotten: a below-cost ask sat resting, filled, and locked in a loss. - `amm swap`: slippage bounds are checked against a fresh quote and refused above 5% (#14). `--max-usdc` was passed through unexamined, so a hand-rounded $56 on a ~$51 quote authorised ~9% slippage in silence. `--max-slippage-pct` derives the bound instead of asking anyone to guess. Both fire under --force, which is where they matter: no prompt is shown, so a loose value would otherwise pass unseen. Claude-Session: https://claude.ai/code/session_01J7bz8aijn2Uwv1yF5rUenW
piekstra-dev
approved these changes
Jul 29, 2026
piekstra-dev
left a comment
piekstra-dev
left a comment
Collaborator
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 8c6a804dfc18
Profile: reviewer - Posting as: piekstra-dev
Summary
| Severity | Findings |
|---|---|
| blocking | 0 |
| major | 0 |
| minor | 0 |
| nits | 0 |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 28s | $0.24 | claude-sonnet-5 | cr 0.10.268
| Field | Value |
|---|---|
| Model | claude-sonnet-5 |
| Reviewers | unavailable |
| Engine | claude_cli · claude-sonnet-5 |
| Reviewed by | cr · piekstra-dev |
| Duration | 28s wall · 25s compute |
| Cost | $0.24 |
| Tokens | 12 in / 1.0k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | claude-sonnet-5 | 6 | 693 | 36.3k | 18.8k | $0.13 | 12s |
| orchestrator-rollup | claude-sonnet-5 | 6 | 351 | 55.7k | 13.7k | $0.10 | 12s |
piekstra
added a commit
that referenced
this pull request
Jul 30, 2026
Both rails in this release exist because the missing guard actually cost money on a live account, not because they seemed prudent: - `quote recenter|provision`: `--min-ask` now DEFAULTS to the position's break-even (#13). It was optional, so it only applied when remembered — and it got forgotten: a below-cost ask sat resting, filled, and locked in a loss. - `amm swap`: slippage bounds are checked against a fresh quote and refused above 5% (#14). `--max-usdc` was passed through unexamined, so a hand-rounded $56 on a ~$51 quote authorised ~9% slippage in silence. `--max-slippage-pct` derives the bound instead of asking anyone to guess. Both fire under --force, which is where they matter: no prompt is shown, so a loose value would otherwise pass unseen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump to cut v0.1.4. Both rails here exist because the missing guard actually cost money on a live account — not because they looked prudent.
--min-askdefaults to the position's break-even--max-usdcwas passed through unexamined, so a hand-rounded $56 on a ~$51 quote authorised ~9% slippage in silence.Both fire under
--force, which is where they matter most: no prompt is shown, so a loose value would otherwise pass unseen — precisely how each original mistake got submitted.--max-slippage-pctnow derives the bound from the quote rather than asking anyone to pick a number, and the 5% threshold is pinned to the platform's own fee load (3% platform + 2% pool LP) rather than to taste.