fix(mask-markup/choice): add fallback dimensions for dragging state i…#2265
Open
PatriciaRomaniuc wants to merge 1 commit into
Open
fix(mask-markup/choice): add fallback dimensions for dragging state i…#2265PatriciaRomaniuc wants to merge 1 commit into
PatriciaRomaniuc wants to merge 1 commit into
Conversation
…n Choice component PIE-693
PatriciaRomaniuc
requested review from
CarlaCostea,
andreeimiron and
arimieandreea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n Choice component PIE-693
https://illuminate.atlassian.net/browse/PIE-693
The issue was that when you start dragging a chip, the code needs to know how big it should be while it's being dragged — basically taking a "snapshot" of its size. But on the very first drag in some environments, that measurement wasn't ready yet, so the code got a size of zero. Zero width and zero height means invisible.
The fix: Added a safety net — if the measurement comes back as zero (or isn't ready), use a sensible minimum size instead. That way the chip is always visible while being dragged, even on the first try.