fix(graphing, charting): render title/label math on first paint via observer PIE-688#3041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://illuminate.atlassian.net/browse/PIE-688
After the React 18 createRoot migration, the title and axis-label math
failed to render on first paint (raw LaTeX shown) and only appeared after
an interaction. createRoot().render() commits asynchronously, so the
queueMicrotask(renderMath) ran before the LaTeX spans were in the DOM.
Replace the queueMicrotask call with the MutationObserver +
requestAnimationFrame pattern already used in multiple-choice/
placement-ordering/passage (PD-5638), so math is typeset after each commit
regardless of timing. Also add math to the title/labels in the charting
demo to exercise the fix.