fix: tilde parser in hb_format not escaped#992
Open
speeddragon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to parse the error message (500) it doesn't escape properly the
~bfrom/~bundlerroute definition (opts).Clanker Description
That crash is from HyperBEAM’s error formatter, not directly from your route. It was passing a literal route string containing ~bundler@1\.0 into io_lib:format/2; ~b was treated as a format directive, causing badarg.
I patched src/core/util/hb_format.erl:401 so no-argument indentation treats strings as literals and escapes all ~ characters before calling io_lib:format/2. I also added a regression test for the exact ^/~bundler@1\.0/tx$ shape.