ci(scorecard): stop uploading SARIF to code scanning#96
Merged
Conversation
Scorecard runs only on the default branch (push/schedule/branch- protection), so the supply-chain/* code-scanning configurations it creates on devel have no counterpart on PR heads. GitHub then can't diff them and emits "Code scanning cannot determine the alerts introduced by this pull request, because 1 configuration ... was not found" on every PR, plus a neutral "CodeQL / skipping" check. Drop the code-scanning upload step (it's optional). Results still go to the OpenSSF API (publish_results: true -> badge unaffected) and to a SARIF artifact; view them on scorecard.dev. Also drop the now-unused security-events: write permission (least-privilege) and a dead pull_request clause in the job `if` (there is no pull_request trigger). Closes #95 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
Upload to code-scanningstep fromscorecard.yml, drop the now-unusedsecurity-events: writepermission, and clean a deadpull_requestclause in the jobif.Why
Scorecard only runs on the default branch (push/schedule/branch-protection), so the
supply-chain/*code-scanning configurations it creates ondevelhave no counterpart on PR heads. GitHub can't compute the alert diff and emits this on every PR:plus a neutral
CodeQL / skippingcheck. CodeQL itself is healthy (Analyze (go)/Analyze (actions)pass).Impact
publish_results: truestill publishes to the OpenSSF API.security-events: writewas only needed for the removed upload.Closes #95
🤖 Generated with Claude Code