fix(csharp-ci): match CodeCoverage 18.9.0 relocated cobertura output#32
Merged
Conversation
Microsoft.Testing.Extensions.CodeCoverage 18.9.0 together with .NET SDK 10.0.3xx solution-level 'dotnet test' resolves the relative --coverage-output against the run-level <working-directory>/TestResults/ instead of each project's bin/Release/<tfm>/TestResults/, so the default tests-glob matched nothing and failed the coverage shard for consumers that bumped the package. Broaden the default with a second glob (the merge step word-splits the input) and update the caller-prerequisites docs, including the stale 18.0.x CodeCoverage ceiling. Validated caller-side in daml-codegen-csharp-internal#585.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-open
Summary
Consumers that bump
Microsoft.Testing.Extensions.CodeCoverageto 18.9.0 hit a hard failure in the Merge per-project cobertura reports step: on .NET SDK 10.0.3xx, solution-leveldotnet testresolves the relative--coverage-outputagainst the run-level<working-directory>/TestResults/instead of each project'sbin/Release/<tfm>/TestResults/, so the defaulttests-globmatches nothing. The relocation needs the combination — 18.8.0 + SDK 10.0.301 and 18.9.0 + SDK 10.0.1xx both keep the per-project layout.First hit and diagnosed in peacefulstudio/daml-codegen-csharp-internal (run 28971047292); the equivalent caller-side override was validated green in daml-codegen-csharp-internal#585 (merge step matched all 10 files at the relocated path).
Changes
tests-globto'tests/**/bin/Release/net*/**/*.cobertura.xml TestResults/**/*.cobertura.xml'— the merge step intentionally word-splits the input underglobstar nullglob, so multiple globs are supported; the second glob is recursive to also cover potential run-subdirectory nesting (**matches zero segments, verified).xunit.v3.mtp-v2shipped; 18.x through 18.9.x is supported, the 19.x empty-output warning stays.TestResults/directory across all projects.Compatibility
Purely additive for default consumers (old layout still matched first; new glob expands to nothing under
nullglobon old toolchains). Consumers passing an explicittests-globare unaffected. Windows shards run the step undershell: bash, so globstar semantics hold.Testing
yaml.safe_load).globstar nullglob(zero-segment and nested matches).TestResults/).