Skip to content

Reject unknown matrix badge statuses#30

Merged
monsieurleberre merged 1 commit into
peacefulstudio:devfrom
maxi-maxima:devloop/reject-unknown-matrix-status
Jul 10, 2026
Merged

Reject unknown matrix badge statuses#30
monsieurleberre merged 1 commit into
peacefulstudio:devfrom
maxi-maxima:devloop/reject-unknown-matrix-status

Conversation

@maxi-maxima

Copy link
Copy Markdown
Contributor

Summary

  • make matrix badge generation reject unknown status tokens instead of coercing them to failing
  • make matrix marker aggregation reject malformed or unknown statuses
  • add regression tests for unknown and malformed status inputs

Closes #26.

Validation

  • python -m unittest discover -s test -p "*matrix*_test.py"
  • git diff --check

Generated with DevLoop-style issue diagnosis and manually reviewed before opening.

@monsieurleberre monsieurleberre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed aggressively as our first outside contribution: line-by-line diff audit, hidden-unicode scan, tree/mode verification vs merge-base, full data-flow trace (job.status → markers → aggregate → write-badges.sh), adversarial injection testing of the error paths, and consumer-repo impact check (canton-ledger-api-csharp, daml-codegen-csharp — both feed pure JSON booleans, zero breakage). 52/52 tests pass locally and CI is green. Implements #26 exactly as specified. LGTM.

@monsieurleberre monsieurleberre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, DevLoop 🤖 Exactly what #26 asked for, regression tests included — we are merging this! 🎉

A quick peek at your GitHub profile suggests you never sleep... 113 repos and counting 😄 Glad this repo made the tour — come back any time! 🤝

In fact, standing invitation: if you feel like a second round, grab any small open issue on peacefulstudio/daml-codegen-csharp or peacefulstudio/canton-ledger-api-csharp — whichever catches your eye — and send a PR. We'd genuinely welcome it 🚀

@monsieurleberre monsieurleberre merged commit cad7bbd into peacefulstudio:dev Jul 10, 2026
2 checks passed
@monsieurleberre

Copy link
Copy Markdown
Contributor

Thank you, DevLoop 🤖 Exactly what #26 asked for, regression tests included — merged! 🎉

A quick peek at your GitHub profile suggests you never sleep... 113 repos and counting 😄 Glad this repo made the tour — come back any time! 🤝

In fact, standing invitation: if you feel like a second round, grab any small open issue on peacefulstudio/daml-codegen-csharp or peacefulstudio/canton-ledger-api-csharp — whichever catches your eye — and send a PR. We'd genuinely welcome it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Badge builders should fail loud on unknown status instead of coercing to 'failing'

2 participants