Skip to content

Validate vers qualifier#186

Open
jaimergp wants to merge 7 commits into
package-url:mainfrom
jaimergp:validate-vers
Open

Validate vers qualifier#186
jaimergp wants to merge 7 commits into
package-url:mainfrom
jaimergp:validate-vers

Conversation

@jaimergp

Copy link
Copy Markdown
Contributor

@pombredanne

Copy link
Copy Markdown
Member

@jaimergp Thanks! can you add a few simple unit tests?

@jaimergp

jaimergp commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

@pombredanne, done!

mprpic
mprpic previously approved these changes May 14, 2025

@mprpic mprpic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaimergp

Copy link
Copy Markdown
Contributor Author

The mypy errors are external to this PR. We are now importing univers, which doesn't feature the py.typed marker file, so mypy complains it won't infer types from that package.

The solution is to add type hints to universe or ignore the import here. Thoughts @pombredanne @mprpic?

…; branch 'main' of github.com:package-url/packageurl-python into validate-vers
@jaimergp

Copy link
Copy Markdown
Contributor Author

As discussed in today's meeting with @pombredanne, I added aboutcode-org/univers#159 to tame the CI here, which is the simplest PR possible to fix this and let mypy infer things in univers.

@jaimergp

Copy link
Copy Markdown
Contributor Author

aboutcode-org/univers#159 was merged a while ago, we just need a new univers release in PyPI and the CI will be green here.

@jaimergp

Copy link
Copy Markdown
Contributor Author

@mprpic @pombredanne - is there anything I can do to request a release for univers so we can get this CI green and then push a packageurl-python release? Thank you! 🙏

@TG1999

TG1999 commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

@jaimergp https://github.com/aboutcode-org/univers/tree/v31.1.0 tag and https://github.com/aboutcode-org/univers/releases/tag/v31.1.0 release on GH are ready, will reflect on Pypi on a few.

@jaimergp

Copy link
Copy Markdown
Contributor Author

CI is finally green 🥳

@jaimergp

Copy link
Copy Markdown
Contributor Author

Gentle ping @pombredanne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants