AO3-6789 Return 404 when accessing challenge on nonexistent collection#5874
Open
gemmie wants to merge 2 commits into
Open
AO3-6789 Return 404 when accessing challenge on nonexistent collection#5874gemmie wants to merge 2 commits into
gemmie wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6789
Purpose
Return 404 when trying to signup to a challenge on nonexistent collection
Testing Instructions
Log in
Try to go to the sign-up page for a challenge in a nonexistent collection, e.g. https://test.archiveofourown.org/collections/FakeCollectionPlaceholderName/signups/new
404 should be returned
Credit
JIRA name: gemmie