AO3-6765 Use ul in skin preview msg again#5873
Open
nicolacleary wants to merge 2 commits into
Open
Conversation
The message is made up of 3 parts and then a button. Before all 4 items were part of the list due to how notices are formed, which was replaced in favour of just separating by br. Change this back so the first 3 parts are in a ul and the button is separated from them and wrapped in a p.
nicolacleary
commented
Jun 11, 2026
Comment on lines
+138
to
+145
| helpers.content_tag( | ||
| :ul, | ||
| helpers.content_tag(:li, t(".skin_title", title: @skin.title)) + | ||
| helpers.content_tag(:li, t(".remove_skin")) + | ||
| helpers.content_tag(:li, t(".tip", site_skin_id: @skin.id)) | ||
| ), | ||
| helpers.content_tag(:p, helpers.link_to(t(".return_to_skin"), skin_path(@skin), class: "action")) | ||
| ].join("\n") |
Contributor
Author
There was a problem hiding this comment.
I basically just took Sarken's suggestion verbatim here - how should I indicate this in the PR?
Collaborator
There was a problem hiding this comment.
This comment's fine! I don't need credit and I'll recuse myself from reviewing 😆
sarken
added
Priority: High - Broken on Test
Bilka2
requested changes
Jun 12, 2026
| t(".tip", site_skin_id: @skin.id), | ||
| helpers.link_to(t(".return_to_skin"), skin_path(@skin), class: "action") | ||
| ].join("<br />") | ||
| helpers.content_tag( |
Contributor
There was a problem hiding this comment.
Could you use helpers.tag.li etc instead of content_tag? The rails docs say that content_tag is legacy: https://api.rubyonrails.org/classes/ActionView/Helpers/TagHelper.html#method-i-content_tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6765
Purpose
Feedback from testing on changes in #5744
The message is made up of 3 parts and then a button.
Before all 4 items were part of the list due to how notices are formed, which was replaced in favour of just separating by br.
Change this so the first 3 parts are in a ul and the button is separated from them and wrapped in a p:
Renders to:
References
#4934
#5744
Credit
nicolacleary (she/her)