AO3-5743 Related works count in dashboard sidebar didn't decrease and sections didn't disappear when a parent work was deleted#5871
Open
ASalbenblatt wants to merge 5 commits into
Open
Conversation
…o a deleted parent work don't show
…who's parent was deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5743
Purpose
This makes it so the related works count in dashboard sidebar goes down when a related work's parent is deleted so it matches the number of works shown. It also hides any sections which would look empty due to the same reason of works with deleted parents
Testing Instructions
First, create a work (the parent work) that will be listed as the inspiration for another work
Now create a work that will cite the previous as its inspiration
Delete the parent work
Look at user B's Related Works page
Credit
FlyingFalcon they/them