AO3-7389 Use find_by! to throw 404 for non existent skins#5870
Open
jmalark wants to merge 1 commit into
Open
Conversation
jmalark
force-pushed
the
AO3-7389-preview-nonexistent-skin-to-404
branch
from
b553636 to
339659b
Compare
jmalark
force-pushed
the
AO3-7389-preview-nonexistent-skin-to-404
branch
from
339659b to
33f049b
Compare
Bilka2
requested changes
Jun 14, 2026
Bilka2
left a comment
Bilka2
left a comment
Contributor
There was a problem hiding this comment.
Not exactly find_by!, but works just as well :D
Please add an rspec test
| # DELETE /skins/1 | ||
| def destroy | ||
| @skin = Skin.find_by(id: params[:id]) | ||
| @skin = Skin.find(params[:id]) |
Contributor
There was a problem hiding this comment.
Could this action use load_skin instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7389
Purpose
When a skin doesn't exist, 404
Credit
Jesse Malark he/him