Take two at a water layer#39
Draft
ratmice wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went ahead and added comments to each of the tags I added.
I couldn't really understand how to do navigation without obstructions like dams/weir/waterfalls,
so I did end up including those, let me know if you really want those omitted.
Looking through the keys, they are pretty sparse for most of the regions I tried.
It seemed like one key would appear on a few items in one area. Ditto for a different key on a different region.
(Like open_water in the regions I tried only appeared in finland)
I'm not sure if you'll actually want
map_from_tag_listfor building a map from related tags.It seemed weird to have separate columns for each vessel kind, for restricting access by kind of boat,
however the majority of these appear to have
cardinality(vessel_access) == 1. So I'm not entirely sure it's the right thing to do.