Skip to content

[GR-75921] Handle new graalpy name in virtualenv seeder #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graalvmbot wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −3
Open

[GR-75921] Handle new graalpy name in virtualenv seeder #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c28e84e
Handle new graalpy name in virtualenv seeder
msimacek May 25, 2026
4fa0726
Tolerate positive signal exit codes in tests
msimacek May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graalpy_virtualenv_seeder/graalpy_virtualenv_seeder/graalpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def set_pyenv_cfg(self):
_get_default_orig = SeederSelector._get_default

def _seeder_selector_get_default_override(self):
if self.interpreter.implementation == "GraalVM":
if self.interpreter.implementation.lower() in ("graalvm", "graalpy"):
return "graalpy"
else:
return _get_default_orig()
Expand Down
6 changes: 4 additions & 2 deletions graalpython/lib-python/3/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3221,7 +3221,8 @@ def test_mymanager(self):
# bpo-30356: BaseManager._finalize_manager() sends SIGTERM
# to the manager process if it takes longer than 1 second to stop,
# which happens on slow buildbots.
self.assertIn(manager._process.exitcode, (0, -signal.SIGTERM))
# GraalPy change: JVM exits with 143 on SIGTERM
self.assertIn(manager._process.exitcode, (0, -signal.SIGTERM, 128 + signal.SIGTERM))

def test_mymanager_context(self):
manager = MyManager(shutdown_timeout=SHUTDOWN_TIMEOUT)
Expand All @@ -3230,7 +3231,8 @@ def test_mymanager_context(self):
# bpo-30356: BaseManager._finalize_manager() sends SIGTERM
# to the manager process if it takes longer than 1 second to stop,
# which happens on slow buildbots.
self.assertIn(manager._process.exitcode, (0, -signal.SIGTERM))
# GraalPy change: JVM exits with 143 on SIGTERM
self.assertIn(manager._process.exitcode, (0, -signal.SIGTERM, 128 + signal.SIGTERM))

def test_mymanager_context_prestarted(self):
manager = MyManager(shutdown_timeout=SHUTDOWN_TIMEOUT)
Expand Down
Loading