Skip to content

Cleanup EdpmMultipathdImage container references#1928

Open
katarimanojk wants to merge 1 commit into
openstack-k8s-operators:mainfrom
katarimanojk:multipathd_container_ref_cleanup
Open

Cleanup EdpmMultipathdImage container references#1928
katarimanojk wants to merge 1 commit into
openstack-k8s-operators:mainfrom
katarimanojk:multipathd_container_ref_cleanup

Conversation

@katarimanojk
Copy link
Copy Markdown

@katarimanojk katarimanojk commented May 21, 2026

multipathd service has been moved from container to host in edpm-ansible (openstack-k8s-operators/edpm-ansible#1060). Clean up the related EdpmMultipathdImage container references following the same pattern as EdpmIscsidImage cleanup:

  • Mark EdpmMultipathdImage field as deprecated in API types with appropriate comments
  • Remove edpm_multipathd_image from inventory variable assignments
  • Comment out RELATED_IMAGE_EDPM_MULTIPATHD_IMAGE_URL_DEFAULT in build configuration
  • Remove edpm_multipathd_image from documentation examples
  • Remove EdpmMultipathdImage test assertions
  • Remove edpmMultipathdImage field documentation

The API fields are preserved but marked as deprecated to maintain backward compatibility. All usage of the field has been removed from the codebase.

Closes: https://redhat.atlassian.net/browse/OSPRH-17429

@openshift-ci openshift-ci Bot requested review from dprince and fultonj May 21, 2026 13:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: katarimanojk
Once this PR has been reviewed and has the lgtm label, please assign slagle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 333227 bytes (325KB)
Base branch size 333227 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@katarimanojk katarimanojk marked this pull request as draft May 21, 2026 13:05
@katarimanojk katarimanojk force-pushed the multipathd_container_ref_cleanup branch from 8f69868 to ef91df0 Compare May 28, 2026 11:47
@katarimanojk katarimanojk marked this pull request as ready for review May 28, 2026 11:50
@openshift-ci openshift-ci Bot requested a review from rebtoor May 28, 2026 11:51
multipathd service has been moved from container to host in
edpm-ansible (openstack-k8s-operators/edpm-ansible#1060).
Clean up the related EdpmMultipathdImage container references
following the same pattern as EdpmIscsidImage cleanup:

- Mark EdpmMultipathdImage field as deprecated in API types with
  appropriate comments
- Remove edpm_multipathd_image from inventory variable assignments
- Comment out RELATED_IMAGE_EDPM_MULTIPATHD_IMAGE_URL_DEFAULT in
  build configuration
- Remove edpm_multipathd_image from documentation examples
- Remove EdpmMultipathdImage test assertions
- Remove edpmMultipathdImage field documentation
- Update disconnected environment docs to use FRR instead of
  multipathd as the example image

The API fields are preserved but marked as deprecated to maintain
backward compatibility. All usage of the field has been removed
from the codebase.

Related: openstack-k8s-operators/edpm-ansible#1060

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@katarimanojk katarimanojk force-pushed the multipathd_container_ref_cleanup branch from ef91df0 to 34d8099 Compare May 28, 2026 11:57
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

@katarimanojk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 34d8099 link true /test precommit-check
ci/prow/openstack-operator-build-deploy-kuttl-4-18 34d8099 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/aed0a0366e5a454698b86b2b31ab831b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 38s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 34m 46s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 35s
openstack-operator-tempest-multinode RETRY_LIMIT in 12m 11s
✔️ openstack-operator-docs-preview SUCCESS in 2m 51s
✔️ openstack-operator-edpm-baremetal-minor-update SUCCESS in 2h 09m 28s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant