Skip to content

REPLACE-WITH-JIRA-KEY: Bump k8s dependencies to v0.36.2 (Go 1.26)#3064

Draft
dfarrell07 wants to merge 5 commits into
openshift:masterfrom
dfarrell07:bump1.36-20260718021309
Draft

REPLACE-WITH-JIRA-KEY: Bump k8s dependencies to v0.36.2 (Go 1.26)#3064
dfarrell07 wants to merge 5 commits into
openshift:masterfrom
dfarrell07:bump1.36-20260718021309

Conversation

@dfarrell07

Copy link
Copy Markdown

Summary

Rebase cluster-network-operator k8s dependencies from v0.35.2 to v0.36.2,
updating Go from 1.25 to 1.26 and the OCP stream from 4.22 to 5.0.

What changed

  • k8s.io/ dependencies*: v0.35.2 → v0.36.2 (k8s 1.36)
  • Go version: 1.25.0 → 1.26.0
  • controller-runtime: v0.22.x → v0.24.1
  • controller-tools: v0.19.x → v0.21.0 (CRD annotation version bump)
  • OCP CI stream: openshift-4.22 → openshift-5.0 (golang-1.26 images)
  • WatchListClient feature gate: disabled in hack/test-go.sh for fake clientset compatibility

Commits

Commit Description Type
f81e270da Rebase k8s-rebase-1.36.2 to k8s 1.36 Mechanical (go.mod, go.sum, vendor)
d3f9242dd Update codegen for k8s 1.36 Mechanical (controller-gen v0.21.0)
4162cbcc2 Update version references for k8s 1.36 Mechanical (Go version in CI/Dockerfile)
e029f1441 Disable WatchListClient feature gate Fix (fake clientset informer hang prevention)
511c7f653 Update OCP stream from 4.22 to 5.0 Fix (golang-1.26 builder images)

Verification

  • go build ./... — PASS
  • go vet ./... — PASS
  • golangci-lint run — PASS (0 issues)
  • go test ./pkg/... ./cmd/... — PASS (1 pre-existing container-only failure in proxyconfig: missing /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem)
  • Test compilation (go test -run='^$' -count=0 ./...) — PASS
  • Independent antagonistic review — APPROVE

Security notes

This rebase fixes 9 CVEs in transitive dependencies:

  • 8 in golang.org/x/crypto (v0.48.0 → v0.52.0)
  • 1 in golang.org/x/net (v0.51.0 → v0.55.1-pre)

All commits carry Assisted-by: Claude Code trailers.

go get k8s.io/api@v0.36.2
go get k8s.io/apiextensions-apiserver@v0.36.2
go get k8s.io/apiserver@v0.36.2
go get k8s.io/client-go@v0.36.2
go get k8s.io/code-generator@v0.36.2
go get k8s.io/component-base@v0.36.2
go get k8s.io/kms@v0.36.2
go get k8s.io/kube-aggregator@v0.36.2
go get k8s.io/kube-proxy@v0.36.2
go get sigs.k8s.io/controller-runtime@v0.24.1
go get github.com/openshift/api
go get github.com/openshift/build-machinery-go
go get github.com/openshift/client-go
go get github.com/openshift/library-go
go get k8s.io/apimachinery
go get k8s.io/gengo/v2
go get k8s.io/klog/v2
go get k8s.io/kube-openapi
go get k8s.io/utils
go get sigs.k8s.io/apiserver-network-proxy/konnectivity-client
go get sigs.k8s.io/controller-tools
go get sigs.k8s.io/json
go get sigs.k8s.io/kube-storage-version-migrator
go get sigs.k8s.io/randfill
go get sigs.k8s.io/structured-merge-diff/v6
go get sigs.k8s.io/yaml
go mod tidy

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
./.ci-operator.yaml
./Dockerfile

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
k8s 1.36 enables WatchListClient by default, which changes the
initial list mechanism to streaming lists. Fake clientsets don't
implement this protocol, causing informer hangs in tests.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
The golang-1.26 builder images exist in the openshift-5.0 stream,
not openshift-4.22. Aligns with cloud-network-config-controller
which already uses golang-1.26-openshift-5.0 for its k8s 1.36
rebase.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2026
@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 98dd99bd-f973-416c-9b0e-0d3f9f8c443b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfarrell07
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant