Skip to content

OCPBUGS-86429: Skip _stackmanager for libreswan 5.x compat#3056

Draft
anuragthehatter wants to merge 1 commit into
openshift:release-4.18from
anuragthehatter:skip-stackmanager-4.18
Draft

OCPBUGS-86429: Skip _stackmanager for libreswan 5.x compat#3056
anuragthehatter wants to merge 1 commit into
openshift:release-4.18from
anuragthehatter:skip-stackmanager-4.18

Conversation

@anuragthehatter

Copy link
Copy Markdown

Summary

Backport of #2885 from release-4.19. Makes the _stackmanager binary call conditional — only runs when the binary exists.

The _stackmanager binary was removed in libreswan 5.3, causing IPsec pod startup failures when upgrading to libreswan 5.x.

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

  • openshift/os: unpin libreswan in RHCOS extensions
  • openshift/machine-config-operator: libreswan 5.x compat changes
  • openshift/cluster-network-operator: this PR
  • openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Backport of openshift#2885 from release-4.19. The _stackmanager binary was
removed in libreswan 5.3, causing IPsec pod startup failures. Wrap
the call in a conditional check so it only runs when the binary exists.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@anuragthehatter: This pull request references Jira Issue OCPBUGS-74205, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • expected dependent Jira Issue OCPBUGS-74139 to target a version in 4.19.0, 4.19.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CORENET-6311 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.z" version, but no target version was set.

Details

In response to this:

Summary

Backport of #2885 from release-4.19. Makes the _stackmanager binary call conditional — only runs when the binary exists.

The _stackmanager binary was removed in libreswan 5.3, causing IPsec pod startup failures when upgrading to libreswan 5.x.

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

  • openshift/os: unpin libreswan in RHCOS extensions
  • openshift/machine-config-operator: libreswan 5.x compat changes
  • openshift/cluster-network-operator: this PR
  • openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ee107b5b-bd2f-4ebb-969b-8327f3dcf5e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bpickard22 and miheer July 15, 2026 15:50
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@anuragthehatter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security baa05ba link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anuragthehatter anuragthehatter changed the title [release-4.18] OCPBUGS-74205,CORENET-6311: Skip _stackmanager for libreswan 5.3+ DNM: Bug 000000: Skip _stackmanager for libreswan 5.x compat Jul 15, 2026
@anuragthehatter
anuragthehatter marked this pull request as draft July 15, 2026 16:30
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@anuragthehatter: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

Backport of #2885 from release-4.19. Makes the _stackmanager binary call conditional — only runs when the binary exists.

The _stackmanager binary was removed in libreswan 5.3, causing IPsec pod startup failures when upgrading to libreswan 5.x.

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

  • openshift/os: unpin libreswan in RHCOS extensions
  • openshift/machine-config-operator: libreswan 5.x compat changes
  • openshift/cluster-network-operator: this PR
  • openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@anuragthehatter anuragthehatter changed the title DNM: Bug 000000: Skip _stackmanager for libreswan 5.x compat OCPBUGS-86429: Skip _stackmanager for libreswan 5.x compat Jul 15, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@anuragthehatter: This pull request references Jira Issue OCPBUGS-86429, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-86429 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of #2885 from release-4.19. Makes the _stackmanager binary call conditional — only runs when the binary exists.

The _stackmanager binary was removed in libreswan 5.3, causing IPsec pod startup failures when upgrading to libreswan 5.x.

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

  • openshift/os: unpin libreswan in RHCOS extensions
  • openshift/machine-config-operator: libreswan 5.x compat changes
  • openshift/cluster-network-operator: this PR
  • openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants