Skip to content

Remove srep-infra-cicd from OWNERS files [SDCICD-1761]#755

Closed
christophermancini wants to merge 1 commit into
openshift:mainfrom
christophermancini:remove-srep-infra-cicd
Closed

Remove srep-infra-cicd from OWNERS files [SDCICD-1761]#755
christophermancini wants to merge 1 commit into
openshift:mainfrom
christophermancini:remove-srep-infra-cicd

Conversation

@christophermancini

@christophermancini christophermancini commented Jun 9, 2026

Copy link
Copy Markdown

The srep-infra-cicd migration is now complete. This PR removes the team as owners from this repository.

Related: Similar cleanup across OpenShift managed services repositories.

Summary by CodeRabbit

  • Chores
    • Updated code review and approval configuration settings.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@christophermancini, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 58 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: be881df8-486b-4e43-953e-12fcee345799

📥 Commits

Reviewing files that changed from the base of the PR and between 814ce27 and 0be9775.

📒 Files selected for processing (1)
  • .tekton/OWNERS

Walkthrough

This PR updates repository ownership configuration by removing the srep-infra-cicd group from two locations: the approvers list in .tekton/OWNERS and the alias definition in OWNERS_ALIASES. These related changes consolidate ownership responsibility.

Changes

Ownership configuration

Layer / File(s) Summary
Remove srep-infra-cicd from approval configuration
.tekton/OWNERS, OWNERS_ALIASES
.tekton/OWNERS removes srep-infra-cicd from the approvers list while introducing an empty reviewers structure. OWNERS_ALIASES deletes the srep-infra-cicd alias entry and its associated user list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR removes srep-infra-cicd from OWNERS files; the custom check for Ginkgo test name stability is not applicable since the project doesn't use Ginkgo and the PR contains no test code changes.
Test Structure And Quality ✅ Passed PR adds 48 new test files using testify/Go testing (testing.T), not Ginkgo. Custom check for Ginkgo test quality is not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies OWNERS configuration files; no new Ginkgo e2e tests are added. The check applies only to new e2e tests with MicroShift-incompatible APIs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. Integration tests use standard Go testify/suite framework, not Ginkgo patterns. The custom check applies only to Ginkgo e2e tests and is not applicable here.
Topology-Aware Scheduling Compatibility ✅ Passed Deployment manifests use topology-safe patterns: webhook has 2 replicas with required anti-affinity and maxUnavailable: 1 (the safe pattern); manager has 1 replica on infra nodes only.
Ote Binary Stdout Contract ✅ Passed PR only modifies OWNERS configuration files (.tekton/OWNERS, OWNERS_ALIASES), not executable code, so no OTE stdout violations possible.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests (It, Describe, Context, When patterns). Added tests use standard Go testing.T or test suite patterns. Check is not applicable.
No-Weak-Crypto ✅ Passed Pull request only modifies OWNERS configuration files to remove a team; no cryptographic code, weak crypto algorithms, or secret comparisons present.
Container-Privileges ✅ Passed PR only modifies OWNERS administrative files, not container or K8s manifests; no privileged container settings present in changes.
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies only OWNERS configuration files (not logging code) and contains no logging statements, sensitive data exposure, or security violations.
Title check ✅ Passed The pull request title directly and accurately summarizes the main change: removing srep-infra-cicd from OWNERS files, matching the actual modifications in both .tekton/OWNERS and OWNERS_ALIASES.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Ajpantuso and ritmun June 9, 2026 13:52
@christophermancini christophermancini changed the title Remove srep-infra-cicd from OWNERS files Remove srep-infra-cicd from OWNERS files [SDCICD-1761] Jun 9, 2026
@christophermancini christophermancini marked this pull request as draft June 9, 2026 14:04
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.21%. Comparing base (b48e996) to head (814ce27).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          62       62           
  Lines        4127     4127           
=======================================
  Hits         2444     2444           
  Misses       1534     1534           
  Partials      149      149           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@christophermancini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 814ce27 link true /test precommit-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: christophermancini
Once this PR has been reviewed and has the lgtm label, please assign varunraokadaparthi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 9, 2026
The srep-infra-cicd migration is complete. This file only contained
srep-infra-cicd as owners and was added by boilerplate during the
Konflux migration.

Removing it allows the .tekton directory to inherit ownership from
the root OWNERS file, which is the correct operator team for this repo.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 9, 2026
@christophermancini

Copy link
Copy Markdown
Author

Closing this PR. The fix will be implemented in the boilerplate update script instead, so repos will get the cleanup automatically during their next bp-update run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants