QueryValidationIT.testAliasToKeywordMultiFieldFailsWithBadRequest: opensearch-project#5532 changed
the SQL error formatter to unwrap ErrorReport to its cause, so the reported type
is now the underlying SemanticCheckException, not the ErrorReport wrapper. Update
the expected error type to match. Query is still correctly rejected (400); only
the envelope type changed.
CalciteExplainIT.testNoMvBasic / testNoMvWithEval: the assertion scanned the full
logical+physical explain YAML for ARRAY_JOIN, but the physical section renders
differently with pushdown disabled (CalciteNoPushdownIT), making the test flaky
on some runners. nomv lowers to MVJOIN -> ARRAY_JOIN, which is stable in the
LOGICAL plan regardless of pushdown (verified with pushdown on and off). Assert
on the logical section only.
Signed-off-by: Eric Wei <mengwei.eric@gmail.com>
Description
Repairs two pre-existing IT failures on
main(both ininteg-test, test-only, no production change).1.
QueryValidationIT.testAliasToKeywordMultiFieldFailsWithBadRequest— #5532 changed the SQL error formatter to unwrapErrorReportto its cause, so the reportedtypeis now the underlyingSemanticCheckException, not theErrorReportwrapper. The query is still correctly rejected with 400; only the error-envelopetypechanged. Updated the expected type to match.2.
CalciteExplainIT.testNoMvBasic/testNoMvWithEval— the assertion scanned the full logical+physical explain YAML forARRAY_JOIN, but the physical section renders differently when pushdown is disabled (CalciteNoPushdownIT), making the test flaky on some runners.nomvlowers toMVJOIN → ARRAY_JOIN, which is stable in the logical plan regardless of pushdown (verified with pushdown on and off). Assert on the logical section only.Testing
Ran against an OpenSearch cluster:
QueryValidationIT— full class passes (target test + siblings).CalciteExplainIT.testNoMvBasic/testNoMvWithEval— pass; logical plan confirmed to containARRAY_JOINwith pushdown both enabled and disabled.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.