chore: refactor api key details for cryptoregion#351
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d2a1429 to
f8c69ec
Compare
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
f8c69ec to
ee66003
Compare
| continue | ||
| } | ||
| regionValues[manager.IsEditableCryptoAccess] = editable | ||
| regionValues.IsEditable = &editable |
There was a problem hiding this comment.
Should we be not also writing back the modified copy?
There was a problem hiding this comment.
No. This field is simply calculated for UI. Holding it as a state would just overly complicate things
There was a problem hiding this comment.
Sorry, meant prior to the return — to write the computed value back into the crypto map (crypto[region] = regionValues) so it's in what gets returned.
What this PR does / why we need it:
Special notes for your reviewer:
Release note: