Skip to content

chore: refactor api key details for cryptoregion#351

Open
jmpTeixeira02 wants to merge 1 commit into
mainfrom
task/keyaccessdetails-refactor
Open

chore: refactor api key details for cryptoregion#351
jmpTeixeira02 wants to merge 1 commit into
mainfrom
task/keyaccessdetails-refactor

Conversation

@jmpTeixeira02

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:


Special notes for your reviewer:


Release note:


@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 416633c3-c571-4415-aae7-0613c8ff4be2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jmpTeixeira02
jmpTeixeira02 force-pushed the task/keyaccessdetails-refactor branch 2 times, most recently from d2a1429 to f8c69ec Compare July 27, 2026 10:33
@jmpTeixeira02
jmpTeixeira02 marked this pull request as ready for review July 27, 2026 10:33
@jmpTeixeira02 jmpTeixeira02 self-assigned this Jul 27, 2026
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
@jmpTeixeira02
jmpTeixeira02 force-pushed the task/keyaccessdetails-refactor branch from f8c69ec to ee66003 Compare July 27, 2026 10:57
continue
}
regionValues[manager.IsEditableCryptoAccess] = editable
regionValues.IsEditable = &editable

@niazkhansap niazkhansap Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be not also writing back the modified copy?

@jmpTeixeira02 jmpTeixeira02 Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This field is simply calculated for UI. Holding it as a state would just overly complicate things

@niazkhansap niazkhansap Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant prior to the return — to write the computed value back into the crypto map (crypto[region] = regionValues) so it's in what gets returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants