Skip to content

8250839: Improve test template SSLEngineTemplate with SSLContextTemplate#809

Open
jerboaa wants to merge 1 commit into
openjdk:pr/808from
jerboaa:jdk-8250839-jdk8u-template-SSLEngineTemplate
Open

8250839: Improve test template SSLEngineTemplate with SSLContextTemplate#809
jerboaa wants to merge 1 commit into
openjdk:pr/808from
jerboaa:jdk-8250839-jdk8u-template-SSLEngineTemplate

Conversation

@jerboaa

@jerboaa jerboaa commented May 27, 2026

Copy link
Copy Markdown
Contributor

Clean (modulo path changes) test-only backport for bringing in JDK-8284047. In particular, this is preparatory work for JDK-8263188 a dependency for JDK-8284047.

Testing

Passed: javax/net/ssl/templates/SSLEngineTemplate.java
Passed: javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java
Passed: javax/net/ssl/templates/SSLSocketTemplate.java
Test results: passed: 3

Thoughts?



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8250839 needs maintainer approval

Integration blocker

 ⚠️ Dependency #808 must be integrated first

Issue

  • JDK-8250839: Improve test template SSLEngineTemplate with SSLContextTemplate (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/809/head:pull/809
$ git checkout pull/809

Update a local copy of the PR:
$ git checkout pull/809
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 809

View PR using the GUI difftool:
$ git pr show -t 809

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/809.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 27, 2026

Copy link
Copy Markdown

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/808 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 27, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 6414dec64a01d94edb57c5380850ef536cd3bcec 8250839: Improve test template SSLEngineTemplate with SSLContextTemplate May 27, 2026
@openjdk

openjdk Bot commented May 27, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 27, 2026
@mlbridge

mlbridge Bot commented May 27, 2026

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Jun 2, 2026

Copy link
Copy Markdown

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk-notifier openjdk-notifier Bot force-pushed the pr/808 branch 2 times, most recently from ee90e96 to 689fa41 Compare June 8, 2026 09:00
8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
@jerboaa jerboaa force-pushed the jdk-8250839-jdk8u-template-SSLEngineTemplate branch from a18ae0c to 42fe7f9 Compare June 8, 2026 09:38
@openjdk

openjdk Bot commented Jun 8, 2026

Copy link
Copy Markdown

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper

bridgekeeper Bot commented Jul 6, 2026

Copy link
Copy Markdown

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jerboaa

jerboaa commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

@jerboaa The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant