feat: simplify retirement cleanup by removing custom redaction value parameters - #38934
Merged
Conversation
rahulkanneri-2u
approved these changes
Jul 29, 2026
robrap
reviewed
Jul 31, 2026
Comment on lines
+1055
to
+1057
| original_username="redacted", | ||
| original_email="redacted", | ||
| original_name="redacted" |
Contributor
There was a problem hiding this comment.
This would follow our earlier patterns more closely:
Suggested change
| original_username="redacted", | |
| original_email="redacted", | |
| original_name="redacted" | |
| original_username="redacted-before-delete", | |
| original_email="redacted-before-delete@safe.com", | |
| original_name="redacted-before-delete" |
Comment on lines
+1090
to
+1091
| assert '"original_username" = \'redacted\'' in sql_lower, ( | ||
| f"UPDATE query missing '\"original_username\" = redacted': {sql_lower}" |
Contributor
There was a problem hiding this comment.
Nit: The default message for failure would probably be fine, and the code would be much simpler to read:
Suggested change
| assert '"original_username" = \'redacted\'' in sql_lower, ( | |
| f"UPDATE query missing '\"original_username\" = redacted': {sql_lower}" | |
| assert '"original_username" = \'redacted\'' in sql_lower |
ktyagiapphelix2u
force-pushed
the
ktyagi/BOMS-529
branch
from
July 31, 2026 17:07
37ea705 to
be11f58
Compare
robrap
approved these changes
Jul 31, 2026
robrap
enabled auto-merge (squash)
July 31, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the user retirement cleanup flow by removing caller-defined redaction override parameters (
redacted_username,redacted_email,redacted_name) across the API endpoint, API client, and CLI script.Since redaction is performed immediately prior to deletion, customizable redaction values add unnecessary complexity. The fields are now hardcoded to
"redacted"in the pre-deletionUPDATEquery.Private Jira Ticket
https://2u-internal.atlassian.net/browse/BOMS-529