fix: drop superadmin entries for user assigments endpoint - #370
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
mariajgrimaldi
left a comment
There was a problem hiding this comment.
LGTM! When you can, could you bump the version? A minor patch would work since this is unused data. Thanks!
|
thanks @mariajgrimaldi for reviewing the PR, I had bumped the version. |
Description
Follows the same approach as #345, which dropped superadmin entries from the assignment list endpoint (
/api/authz/v1/assignments/). This applies it to the single-user endpoint,/api/authz/v1/users/<username>/assignments/.TeamMemberAssignmentsAPIView.getno longer callsget_superadmin_assignments(user_external_keys=[username]). It now returns role assignments only, fromget_visible_user_role_assignments_filtered_by_current_user.Related information
Fixes openedx/frontend-app-admin-console#180
Testing Instructions
/api/authz/v1/users/<superadmin_username>/assignments/and verify nodjango.staffordjango.superuserentries appear.Merge checklist:
Check off if complete or not applicable: