PDF: stage-1 roadmap wrap-up — summary + drop sub-stage tags from code#536
Merged
Conversation
andiwand
force-pushed
the
pdf-composite-cid-fonts-cjk
branch
from
bf136a1 to
1d9079a
Compare
andiwand
force-pushed
the
pdf-plan-stage1-wrapup
branch
from
7ea4ab0 to
ee4b884
Compare
…vers Stage 1 (code → Unicode extraction) is functionally done: 1.1 (ToUnicode multi-byte), 1.2 (simple-font /Encoding + AGL) and 1.3 (Type0 + Identity + /ToUnicode + predefined Unicode CMaps) all landed and cover the corpus. The nothing-implementable-now remainder is moved out of stage 1: - legacy CJK code→CID CMaps + CID→Unicode tables → tracked under Other known gaps (large data; generator scaffolding already landed), - embedded-font reverse map (was 1.4) → folded into stage 3 (font reading), - "no Unicode" run marking + /ActualText (was 1.5) → folded into stage 2. Stage 1 now reads as a goal + achieved summary. Updated the few code comments that referenced the relocated sub-stage numbers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The roadmap sub-stage numbers (stage 1.1/1.2/1.3, part A/part B) tagged onto code and test comments only said which roadmap sub-stage implemented a line; the technical explanation stands on its own, and the numbering now lives only in the roadmap. Strip them, keeping each comment's substance and the live "stage 2"/"stage 3" forward pointers. Comment-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andiwand
force-pushed
the
pdf-plan-stage1-wrapup
branch
from
ee4b884 to
95520c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #534 (stage 1.3 part B). Retarget to
mainas the stack merges.Stage 1 (the code → Unicode extraction chain) is functionally done — 1.1
(
ToUnicodemulti-byte), 1.2 (simple-font/Encoding+ AGL) and 1.3 (Type0 +Identity-H/V+/ToUnicode+ predefined Unicode CMaps) all landed and coverthe corpus. This PR is pure wrap-up; no behaviour change.
Roadmap (
src/odr/internal/pdf/AGENTS.md)summary (the mechanics already live in What works → Fonts / text mapping).
data; generator scaffolding already landed);
/ActualText(was 1.5) → stage 2.Code/test comments
stage 1.1/1.2/1.3,part A/part B)from comments across the PDF module and its tests — they only said which
roadmap sub-stage implemented a line and add no value in the code. Substance
and the live
stage 2/stage 3forward pointers are kept. Comment-only.🤖 Generated with Claude Code