Version 0.20260727.0 - #534
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs a release/version bump to 0.20260727.0, updates a few build/dependency versions (and corresponding Bun lockfiles), and expands the renderer README with deployment guidance for cross-origin isolation required by libOpenCOR.
Changes:
- Bump package versions to
0.20260727.0(root + renderer) and update dependency versions (e.g.,postcss,tar) with lockfile refreshes. - Add a “Deployment” section to
src/renderer/README.mddescribing COOP/COEP setup for cross-origin isolation. - Minor README cleanup (Repobeats image alt text).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/README.md | Adds deployment documentation and refines usage/props documentation. |
| src/renderer/package.json | Bumps renderer package version and updates postcss. |
| src/renderer/bun.lock | Updates lockfile to reflect renderer dependency changes. |
| README.md | Adjusts Repobeats image alt text. |
| package.json | Bumps root version and updates postcss/tar. |
| bun.lock | Updates lockfile to reflect root dependency changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
src/renderer/README.md:78
- The README now states the
themeprop is simply "The theme to use", but the implementation appliesprops.themeonce during setup (setTheme(props.theme)) and does not watch for changes. This documentation change makes the API behavior unclear/incorrect for consumers expecting reactivity.
| `theme` | `'light'` \| `'dark'` \| `'system'` | `'system'` | The theme to use. |
src/renderer/README.md:65
- The guidance for serving libOpenCOR from a different origin is incorrect: setting
Cross-Origin-Embedder-Policyon.js/.wasmsubresource responses does not make them loadable underCOEP: require-corp. Cross-origin module/wasm loads need to be CORS-enabled (and optionally CORP), otherwise the browser will still block them.
On the other hand, if you serve it from a different path on a different origin, then they need a way to signal that they can be loaded cross-origin under COEP. In practice, a straightforward approach that works across server setups is to set the same `Cross-Origin-Embedder-Policy` header already used on the HTML page. While COEP is semantically a document-level policy, Web browsers ignore it on subresource responses, so setting it here is harmless and avoids subtle server-specific issues with other headers. With Apache, place a `.htaccess` file in the download directory (or one of its parent directories):
```apache
<IfModule mod_headers.c>
<FilesMatch "\.(js|wasm)$">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.