Add auto_stop flag check on backend for confirmation dialog.#302
Open
keevindoherty wants to merge 1 commit into
Open
Add auto_stop flag check on backend for confirmation dialog.#302keevindoherty wants to merge 1 commit into
keevindoherty wants to merge 1 commit into
Conversation
Author
I'll take a quick pass at trying to fix this later today or tomorrow before it's ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to opencap-org/opencap-viewer#534
This PR adds the
auto_stopparameter used in opencap-org/opencap-viewer#534 to allow a user to abort neutral pose processing.It's worth noting this is kind of a hack. Here we simply won't stop recording until a user moves through the confirmation dialog. I think what you'd probably prefer is to stop the recording after 2 seconds in any case, and simply not proceed with processing that data.
cc: @ashcollimore
Testing
I didn't have a straightforward way to quickly test this locally, but I'm happy to take suggestions if you'd prefer I test this on my end.