Skip to content

test(e2e): add Behave step definitions for context merging#611

Open
karnyadavdev wants to merge 2 commits into
open-feature:mainfrom
karnyadavdev:fix/context-merging-e2e
Open

test(e2e): add Behave step definitions for context merging#611
karnyadavdev wants to merge 2 commits into
open-feature:mainfrom
karnyadavdev:fix/context-merging-e2e

Conversation

@karnyadavdev
Copy link
Copy Markdown

Taking over PR #593 to add the required DCO signatures.

Closes #593

Closes open-feature#593

Signed-off-by: Karan Yadav <47368518+karnyadavdev@users.noreply.github.com>
@karnyadavdev karnyadavdev requested review from a team as code owners June 2, 2026 22:58
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces behavior-driven development (BDD) test steps and environment setup for testing OpenFeature context merging across various levels (API, Transaction, Client, Invocation, and Before Hooks). The feedback suggests improving the step definitions by leveraging the built-in merge method of EvaluationContext to reduce duplication, and adding defensive checks for context.precedence_levels and context.provider to prevent unhelpful AttributeError exceptions if the tests are executed out of order.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/features/steps/context_merging_steps.py Outdated
Comment thread tests/features/steps/context_merging_steps.py Outdated
Comment thread tests/features/steps/context_merging_steps.py Outdated
Signed-off-by: Karan Yadav <47368518+karnyadavdev@users.noreply.github.com>
@karnyadavdev
Copy link
Copy Markdown
Author

review and merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant