Skip to content

fix: take into account a nil returned by get_parser#518

Open
faergeek wants to merge 1 commit into
numToStr:masterfrom
faergeek:nvim-0.12-compatibility
Open

fix: take into account a nil returned by get_parser#518
faergeek wants to merge 1 commit into
numToStr:masterfrom
faergeek:nvim-0.12-compatibility

Conversation

@faergeek
Copy link
Copy Markdown

Fixes #517

Related change in neovim:
neovim/neovim@fd1e019

@faergeek faergeek marked this pull request as ready for review March 21, 2026 06:18
@JamesWidman
Copy link
Copy Markdown

Given that there's about 2 years of PRs that have not yet received a reply from the repo owner, it looks as if the repo is unmaintained, so it might be best if someone were to become a maintainer with their own fork.

@WillScarlettOhara
Copy link
Copy Markdown

Or switch to mini.comment or ts-comments.nvim ;)

@rseichter
Copy link
Copy Markdown

@WillScarlettOhara Fair point. I tried mini.comment and can't spot a difference so far. Apparently I don't use any particularly fancy moves when dealing with comments. 😉

@faergeek
Copy link
Copy Markdown
Author

faergeek commented Apr 5, 2026

@rseichter there's also a builtin commenting support based on mini.comment. :h commenting

@rseichter
Copy link
Copy Markdown

@faergeek So what you are telling me is that I could have dropped Comment.nvim a full two years ago, and never have run into the nil problem at all? That would have been nice...

@faergeek
Copy link
Copy Markdown
Author

faergeek commented Apr 5, 2026

@rseichter Yep. So all that's left is to invent a time machine :-)

@rseichter
Copy link
Copy Markdown

@faergeek Tempting. Alas, I am a little busy right now, so I'll have to look into building a time machine some other... time. Or is it "will have been looking"? Dang, temporal grammar is hard. 🤓

@cschindlbeck
Copy link
Copy Markdown

I replaced numToStr/Comment.nvim with echasnovski/mini.comment in my Lazy setup, here are the changes you need:

cschindlbeck/nvim@7d954db

@rseichter
Copy link
Copy Markdown

@cschindlbeck The paths for the mini plug-in suite have changed, see here. Besides, as mentioned above, the mini.comment plugin was integrated into Neovim two years ago, i.e. loading this plugin is no longer required.

@cmon1701
Copy link
Copy Markdown

Hello,
why is this pull request not accepted yet, is there a problem?
(I'm no expert on Github).

@rseichter
Copy link
Copy Markdown

As mentioned in this comment, there have been no commits made in this repository for two years. That seems to line up with the time of Neovim adding its own, internal comment support. I therefore share the impression that the Comment.nvim repo should be considered dead.

hectron added a commit to braintreeps/neovim-dotfiles that referenced this pull request May 20, 2026
`Comment.nvim` stopped active development about 2 years ago. The
implementation for commenting relied on an old API that hasn't yet been
patched.

Almost two months ago, this was opened to handle it but there hasn't
been any progress: numToStr/Comment.nvim#518

Since then, Neovim has supported commenting using identical keymaps
powered by Treesitter and commentstring (`:h commenting` and `:h
commentstring`).

Let's just use native Neovim functionality!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message "[Comment.nvim] nil" when plugin is used with vim.pack

7 participants