Skip to content

fetch: fix issue 4058#5456

Merged
mcollina merged 3 commits into
nodejs:mainfrom
KhafraDev:fix-issue-4058
Jun 29, 2026
Merged

fetch: fix issue 4058#5456
mcollina merged 3 commits into
nodejs:mainfrom
KhafraDev:fix-issue-4058

Conversation

@KhafraDev

@KhafraDev KhafraDev commented Jun 28, 2026

Copy link
Copy Markdown
Member

closes #5455
fixes #4058 (tbh didn't even bother reading the ai slop test so can't really confirm 🤷)

Co-authored-by: cesarvspr <vinicius_spr@hotmail.com>
the fetch spec is written so beautifully
@KhafraDev

Copy link
Copy Markdown
Member Author

The fetch spec is so well written, unironically. This shortcut only works for this once instance of cloning the request, which is why the note was added in #http-network-or-cache-fetch and not #concept-request-clone.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (0f1f890) to head (f9d6e57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5456   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         110      110           
  Lines       37106    37115    +9     
=======================================
+ Hits        34682    34691    +9     
  Misses       2424     2424           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b13152e into nodejs:main Jun 29, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request stream contents are kept in memory when using fetch

3 participants