feat: add bookmarks plugin - #132
Draft
dunarand wants to merge 5 commits into
Draft
Conversation
Removed invalid tag and noctalia version field
dunarand
marked this pull request as draft
July 28, 2026 23:35
Author
|
Converted the PR to draft because I thought I've included all the features I wanted but came up with two improvements. I'll mark it "Ready for review" after I ship the features:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
dunarand/bookmarksplugin.toml)What it does
Allows users to create a list of bookmarks that each get a glyhp, a label, a shell command to execute, and an optional description. Allows for 1 level deep nesting by using "folders".
Saved bookmarks are written to either the default location
$NOCTALIA_STATE_HOME/plugins/data/dunarand/bookmarks/data.json, or the user can specify the file/location.The panel can be opened via
or by using the bar widget shipped with the plugin.
External dependencies
None
Testing
Screenshots / Videos
Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
licensedeclared inplugin.toml.