Skip to content

Create guide for new figure/table developers#294

Merged
sbreitbart-NOAA merged 9 commits into
mainfrom
copilot/inspect-figures-and-tables
Jul 14, 2026
Merged

Create guide for new figure/table developers#294
sbreitbart-NOAA merged 9 commits into
mainfrom
copilot/inspect-figures-and-tables

Conversation

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Create a figure/table workflow guide and add it to the bottom of CONTRIBUTING.md.

@sbreitbart-NOAA sbreitbart-NOAA changed the title Move the figure/table workflow guide into CONTRIBUTING.md Create guide for new figure/table developers Jul 9, 2026
@sbreitbart-NOAA sbreitbart-NOAA marked this pull request as ready for review July 9, 2026 20:18
@sbreitbart-NOAA sbreitbart-NOAA force-pushed the copilot/inspect-figures-and-tables branch from f1b0260 to 766a32e Compare July 9, 2026 20:25
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated

@Schiano-NOAA Schiano-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! I made some comments and suggestions for changes. I think the last thing it needs is a mention that all figures or tables get returned at the end of the function regardless if it's exported or not. The contributor does not need to add return() of the table or figure when it's at the end of the function.

sbreitbart-NOAA and others added 2 commits July 13, 2026 13:47
Co-authored-by: Sam (Schiano) Bredeck <125507018+Schiano-NOAA@users.noreply.github.com>
Co-authored-by: Sam (Schiano) Bredeck <125507018+Schiano-NOAA@users.noreply.github.com>
@sbreitbart-NOAA sbreitbart-NOAA force-pushed the copilot/inspect-figures-and-tables branch 2 times, most recently from 6825ef9 to 086a1dd Compare July 14, 2026 13:37
@sbreitbart-NOAA

Copy link
Copy Markdown
Collaborator

This is a great start! I made some comments and suggestions for changes. I think the last thing it needs is a mention that all figures or tables get returned at the end of the function regardless if it's exported or not. The contributor does not need to add return() of the table or figure when it's at the end of the function.

Thanks so much for your helpful comments, Sam. I've updated the guide to address your comments, including how figures/tables are returned even if they're not exported.

@Schiano-NOAA Schiano-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@sbreitbart-NOAA sbreitbart-NOAA merged commit 511223e into main Jul 14, 2026
8 checks passed
@sbreitbart-NOAA sbreitbart-NOAA deleted the copilot/inspect-figures-and-tables branch July 14, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants