feat: prepare v22 release#5182
Open
timdeschryver wants to merge 2 commits into
Open
Conversation
Comment on lines
+165
to
+196
| BEFORE: | ||
|
|
||
| The `selectId` function in the entity adapter configuration has a | ||
| `string | number` return type. | ||
|
|
||
| AFTER: | ||
|
|
||
| The `selectId` function in the entity adapter configuration is inferred | ||
| from the adapter configuration. The return type is `string` or `number`, | ||
| depending on the implementation of the `selectId` function. | ||
| If no `selectId` function is provided, the default implementation infers | ||
| the return type from the `id` property of the entity. | ||
|
|
||
| BEFORE: | ||
|
|
||
| ```ts | ||
| interface User { | ||
| uid: string; | ||
| name: string; | ||
| } | ||
|
|
||
| const adapter = createEntityAdapter<User>({ | ||
| selectId: (user) => user.uid, | ||
| }); | ||
|
|
||
| // `id` is typed as string | number | ||
| adapter.getInitialState({ | ||
| selectedId: null as string | number | null, | ||
| }); | ||
| ``` | ||
|
|
||
| AFTER: |
Member
There was a problem hiding this comment.
Instead of 2 before/after sections, let's have single before/after for better readability (text + code example for both). Also, double check the code example in before section, it doesn't seem correct. It can be the same as the one in after section, just showing a different type
|
Do one of you already know when ngrx signal store for ng22 will be released? Thank you in advance. |
Member
Author
See #5158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information