Skip to content

porting subworkflow Bam applybqsr to nf core modules#12188

Open
agrima2010 wants to merge 25 commits into
masterfrom
bam_applybqsr
Open

porting subworkflow Bam applybqsr to nf core modules#12188
agrima2010 wants to merge 25 commits into
masterfrom
bam_applybqsr

Conversation

@agrima2010

Copy link
Copy Markdown

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@github-actions github-actions Bot added size/l and removed size/m labels Jun 29, 2026
Comment thread subworkflows/nf-core/bam_applybqsr/tests/main.nf.test Outdated
Comment thread subworkflows/nf-core/bam_applybqsr/tests/main.nf.test Outdated
Comment on lines +7 to +8
include { SAMTOOLS_MERGE as MERGE_BAM } from '../../../modules/nf-core/samtools/merge/main'
include { SAMTOOLS_MERGE as MERGE_CRAM } from '../../../modules/nf-core/samtools/merge/main'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include { SAMTOOLS_MERGE as MERGE_BAM } from '../../../modules/nf-core/samtools/merge/main'
include { SAMTOOLS_MERGE as MERGE_CRAM } from '../../../modules/nf-core/samtools/merge/main'
include { SAMTOOLS_MERGE as MERGE_BAM } from '../../../modules/nf-core/samtools/merge'
include { SAMTOOLS_MERGE as MERGE_CRAM } from '../../../modules/nf-core/samtools/merge'

Comment on lines +16 to +17
bam // channel: [mandatory] [ meta, bam, bai, recal ]
cram // channel: [mandatory] [ meta, cram, crai, recal ]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bam // channel: [mandatory] [ meta, bam, bai, recal ]
cram // channel: [mandatory] [ meta, cram, crai, recal ]
reads // channel: [mandatory] [ meta, reads, index, recal ]
``

@github-actions github-actions Bot added size/m and removed size/l labels Jun 29, 2026
@agrima2010 agrima2010 requested a review from a team as a code owner June 30, 2026 12:01
@agrima2010 agrima2010 requested a review from a team as a code owner June 30, 2026 12:01
Comment thread .vscode/settings.json Outdated
Comment thread modules/nf-core/gatk4/applybqsr/main.nf Outdated
Comment thread modules/nf-core/gatk4/applybqsr/main.nf Outdated
Comment thread subworkflows/nf-core/bam_applybqsr/tests/main.nf.test.snap
Comment thread subworkflows/nf-core/cram_qc_mosdepth_samtools/main.nf
agrima2010 and others added 4 commits June 30, 2026 14:33
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants