fix(headings): skip headings in details in table of contents#8653
Open
mejo- wants to merge 1 commit into
Open
Conversation
Fixes: #8582 Signed-off-by: Jonas <jonas@freesources.org>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
max-nextcloud
approved these changes
May 27, 2026
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good.
While you're at it... shall we do the same for quotes?
Member
Author
Not sure about that one. Headings in details are inaccessible from table of contents, as details are collapsed when loading the page. Headings in quotes are accessible. Still they're probably not meant to be part of the page structure usually. Are you in favor of skipping them as well? I don't have a strong opinion and think I'd be fine with either option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8582
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)